Review 9.5 Merged

66589[BUGFIX] Do not use AdminPanel reference in EXT:frontend code

Benni Mack CR +2 V +2 Easy +7 −2 updated 11/17/20, 08:06

Commit message

With this change an undefined symbol is included when not having
AdminPanel loaded: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66218

This change aims to change the logic for checking if the preview
flag is enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 11/16/20, 14:18

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php
  2. Benni Mack commented on patch set 2 11/16/20, 14:19

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 2 11/16/20, 14:19

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V -1 11/16/20, 14:21 Completed build in 33s on Mon, 16 Nov, 02:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-899

  5. TYPO3com voted on patch set 2 V +1 11/16/20, 14:40 Completed build in 19m 37s on Mon, 16 Nov, 02:40 PM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-900

  6. Benni Mack voted on patch set 2 V +2 CR +2 11/17/20, 08:06

  7. Benni Mack merged patch set 3 11/17/20, 08:06