Review 9.5 Merged

66591[BUGFIX] Do not try to evaluate fe_groups for page overlays

Benni Mack CR +2 V +2 Easy +30 −9 updated 11/17/20, 08:46

Commit message

The access settings is an exclude field and hence
the value is synchronized to the translation.
Fetching the translation overlay therefore does
not need to evaluate the fe_groups again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 11/17/20, 08:19

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php * typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php * typo3/sysext/core/Tests/Functional/Fixtures/pages.xml
  2. TYPO3com voted on patch set 1 V -1 11/17/20, 08:20 Completed build in 32s on Tue, 17 Nov, 08:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-902

  3. Benni Mack uploaded patch set 2 11/17/20, 08:27

  4. Benni Mack commented on patch set 2 11/17/20, 08:27

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 11/17/20, 08:40 Completed build in 12m 16s on Tue, 17 Nov, 08:40 AM Test Summary: 75267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-903

  6. Benni Mack voted on patch set 2 V +2 CR +2 11/17/20, 08:46

  7. Benni Mack merged patch set 3 11/17/20, 08:46