Review main Merged Breaking

66595[!!!][TASK] Remove unused possibility for user-based authentication timeout field

Benni Mack CR +2 V +2 Normal +52 −15 updated 11/09/20, 15:31

Commit message

The AbstractUserAuthentication property "auth_timeout_field"
was used in the past (until TYPO3 8.0) to be filled for backend purposes
with "$GLOBALS['TYPO3_CONF_VARS']['BE']['sessionTimeout']"
and for backend with the lifetime field.

This field was not properly filled since TYPO3 v8.0, see
issue #68890 for details.

As the field had a dual-use but now is unused, it is properly
removed as TYPO3 Core never implemented this on a per-userrecord-basis
but handles this via the sessionTimeout propery now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 710

  1. Benni Mack uploaded patch set 1 11/09/20, 14:08

  2. Benni Mack uploaded patch set 2 11/09/20, 14:24

  3. TYPO3com voted on patch set 1 V +1 11/09/20, 14:25 Completed build in 16m 24s on Mon, 9 Nov, 02:25 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7204

  4. Benni Mack updated the commit message in patch set 3 11/09/20, 14:39

  5. TYPO3com voted on patch set 2 V +1 11/09/20, 14:47 Completed build in 15m 47s on Mon, 9 Nov, 02:47 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7205

  6. TYPO3com voted on patch set 3 V +1 11/09/20, 14:56 Completed build in 14m 35s on Mon, 9 Nov, 02:56 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7206

  7. Markus Klein voted on patch set 3 V +1 CR +1 11/09/20, 15:01

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 11/09/20, 15:02

  9. Benni Mack voted on patch set 3 V +2 CR +2 11/09/20, 15:31

  10. Benni Mack merged patch set 4 11/09/20, 15:31