Review main Merged Breaking

66596[!!!][TASK] Remove feature security.frontend.keepSessionDataOnLogout

Benni Mack CR +2 V +2 Normal +47 −38 updated 11/10/20, 10:31

Commit message

The feature flag "security.frontend.keepSessionDataOnLogout"
was introduced as part of a security bugfix to still enable frontend
users to keep their session data even if they have logged out,
where the session data was transferred and migrated to an
anonymous session.

Since this feature in general is insecure, as people who log off
from a public computer would keep session data on that machine,
the functionality is fully removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Benni Mack uploaded patch set 1 11/09/20, 19:51

  2. TYPO3com voted on patch set 1 V +1 11/09/20, 20:03 Completed build in 11m 43s on Mon, 9 Nov, 08:03 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7211

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/10/20, 09:50

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/10/20, 10:31

  5. Christian Kuhn merged patch set 2 11/10/20, 10:31