Review main Merged

66606[TASK] Respect CGL for TsConfig

Eric Chavaillaz CR +2 V +2 Hard +313 −313 updated 11/20/20, 13:05

Commit message

The TsConfig CGL are described:
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/CodingGuidelines/CglTsConfig.html

This patch ensure that those rules are now respected everywhere in the core.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 69

  1. Eric Chavaillaz uploaded patch set 1 11/11/20, 15:22

  2. TYPO3com voted on patch set 1 V +1 11/11/20, 15:34 Completed build in 11m 34s on Wed, 11 Nov, 03:34 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7244

  3. Anja Leichsenring updated the commit message in patch set 2 11/11/20, 21:28

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/11/20, 21:29

  5. TYPO3com voted on patch set 2 V -1 11/11/20, 21:44 Completed build in 15m 58s on Wed, 11 Nov, 09:44 PM Test Summary: 1 of 74129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7256

  6. TYPO3com voted on patch set 2 V +1 11/11/20, 22:06 Completed build in 54m 23s on Wed, 11 Nov, 10:06 PM Test Summary: 73644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7256

  7. Richard Haeser voted on patch set 2 CR +1 11/20/20, 12:56

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 11/20/20, 13:04

  9. Christian Kuhn merged patch set 3 11/20/20, 13:05