Review 9.5 Merged

66607[DOCS] Improve documentation for Fluid f:translate viewhelper

Peter Kraume CR +2 V +2 Easy +12 −4 updated 11/12/20, 17:51

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Chris Müller +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Peter Kraume uploaded patch set 1 11/11/20, 16:01

  2. TYPO3com voted on patch set 1 V +1 11/11/20, 16:15 Completed build in 14m 15s on Wed, 11 Nov, 04:15 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-880

  3. Markus Klein commented on patch set 1 11/11/20, 18:51

    TranslateViewHelper.php:73 Unresolved

    someKey

    TranslateViewHelper.php:74 Unresolved

    I'd use %1$s and %2$s to make clear that you can use positional arguments
  4. Sybille Peters commented on patch set 1 V +1 CR +1 11/11/20, 18:51

    I love it! It is much clearer now.
  5. Anja Leichsenring commented on patch set 1 CR -1 11/11/20, 19:01

    the remarks by Markus also apply to master and 10.4, therefor I propose a different path: please create a master change, that takes care of the comments there, also for v10. The v9 backport will then contain the whole comment block as proposed here.
  6. Oli Bartsch commented on patch set 1 11/11/20, 19:43

    > Patch Set 1: Code-Review-1 > > the remarks by Markus also apply to master and 10.4, therefor I propose a different path: > please create a master change, that takes care of the comments there, also for v10. The v9 backport will then contain the whole comment block as proposed here. Using %s here was intended. See comment from Mathias in https://review.typo3.org/c/Packages/TYPO3.CMS/+/65962: > Actually "%1$s" and "%2$s" would be fine but this should be moved to a different example since the point is mostly about reordering arguments for various languages and also the option to use the same argument multiple times. So this basic example should indeed stick to "%s". Therefore I would suggest to either let this (backport) patch as it is and/or add an example for the position specifiers in a separate master patch (which can then also be backported).
  7. Peter Kraume uploaded patch set 2 11/12/20, 16:13

  8. TYPO3com voted on patch set 2 V +1 11/12/20, 16:27 Completed build in 13m 55s on Thu, 12 Nov, 04:27 PM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-885

  9. Anja Leichsenring updated the commit message in patch set 3 11/12/20, 16:32

  10. TYPO3com voted on patch set 3 V +1 11/12/20, 16:51 Completed build in 18m 11s on Thu, 12 Nov, 04:51 PM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-886

  11. Chris Müller voted on patch set 3 CR +1 11/12/20, 16:53

  12. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/12/20, 17:51

  13. Anja Leichsenring merged patch set 4 11/12/20, 17:51