Review main Abandoned

66608[FEATURE] Add ignore button to skip link checking for specific URLs

Sybille Peters CR 0 V 0 Expert +1106 −48 updated 05/14/21, 14:12

Commit message

This feature adds an ignore button for each broken external link to
the linkvalidator report. The button makes it possible to add the
link target to a list of to be ignored URLs.

The button is only available for admins by default, but access can
be granted to editors.

The advantage is that falsely reported broken Links can be eliminated
from the linkvalidator report and will no longer be checked.

The ignoring can be done by exact match or for an entire domain.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 20

Review log 2442

Show 1017 earlier messages
  1. Sybille Peters uploaded patch set 1 11/11/20, 17:26

  2. Sybille Peters marked it work in progress 11/11/20, 17:26

  3. TYPO3com voted on patch set 1 V +1 11/11/20, 17:39 Completed build in 12m 51s on Wed, 11 Nov, 05:39 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7248

  4. Sybille Peters wrote 11/11/20, 18:17

    Topic set to Linkvalidator
  5. Sybille Peters uploaded patch set 2 11/14/20, 19:38

  6. TYPO3com voted on patch set 2 V -1 11/14/20, 19:39 Completed build in 22s on Sat, 14 Nov, 07:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7307

  7. Sybille Peters uploaded patch set 3 11/14/20, 19:40

  8. TYPO3com voted on patch set 3 V -1 11/14/20, 19:41 Completed build in 32s on Sat, 14 Nov, 07:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7309

  9. Sybille Peters uploaded patch set 4 11/15/20, 16:52

  10. Sybille Peters uploaded patch set 5 11/15/20, 16:53

  11. TYPO3com voted on patch set 4 V -1 11/15/20, 17:05 Completed build in 12m 52s on Sun, 15 Nov, 05:05 PM Test Summary: 2786 of 74126 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7320

  12. TYPO3com voted on patch set 5 V -1 11/15/20, 17:09 Completed build in 14m 20s on Sun, 15 Nov, 05:09 PM Test Summary: 3176 of 74126 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7321

  13. Sybille Peters uploaded patch set 6 11/15/20, 18:17

  14. TYPO3com voted on patch set 6 V +1 11/15/20, 18:29 Completed build in 11m 54s on Sun, 15 Nov, 06:29 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7323

  15. Sybille Peters uploaded patch set 7 11/19/20, 17:52

  16. TYPO3com voted on patch set 7 V +1 11/19/20, 18:08 Completed build in 14m 40s on Thu, 19 Nov, 06:08 PM Test Summary: 73737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7431

  17. Sybille Peters commented on patch set 7 11/19/20, 18:09

    This change is ready for review.
  1. Sybille Peters commented on patch set 7 CR -1 11/20/20, 15:23

    Fixing merge conflict
  2. Sybille Peters uploaded patch set 8 11/20/20, 15:25

  3. Sybille Peters wrote 11/20/20, 15:26

    Description set to "Fix merge conflicts"
  4. TYPO3com voted on patch set 8 V +1 11/20/20, 15:49 Completed build in 11m 33s on Fri, 20 Nov, 03:49 PM Test Summary: 32403 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7476

  5. Sybille Peters uploaded patch set 9 11/20/20, 18:28

  6. TYPO3com voted on patch set 9 V -1 11/20/20, 18:39 Completed build in 10m 51s on Fri, 20 Nov, 06:39 PM Test Summary: 2 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7495

  7. Sybille Peters marked it work in progress 11/20/20, 18:46

  8. Sybille Peters rebased onto patch set 10 11/25/20, 14:38

  9. TYPO3com voted on patch set 10 V -1 11/25/20, 14:50 Completed build in 11m 18s on Wed, 25 Nov, 02:50 PM Test Summary: 2 of 32286 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7570

  10. TYPO3com commented on patch set 10 11/25/20, 18:15 Completed build in 15m 20s on Wed, 25 Nov, 06:15 PM Test Summary: 3 of 32649 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7581

  11. TYPO3com commented on patch set 10 11/25/20, 18:19 Completed build in 11m 38s on Wed, 25 Nov, 06:19 PM Test Summary: 2 of 32649 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7582

  12. Sybille Peters uploaded patch set 11 12/06/20, 16:31

  13. TYPO3com voted on patch set 11 V -1 12/06/20, 16:40 Completed build in 08m 40s on Sun, 6 Dec, 04:40 PM Test Summary: 2 of 32668 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7870

  14. Sybille Peters uploaded patch set 12 12/06/20, 16:48

  15. Sybille Peters commented on patch set 12 12/06/20, 16:48

    This change is ready for review.
  16. TYPO3com voted on patch set 12 V +1 12/06/20, 16:57 Completed build in 09m 41s on Sun, 6 Dec, 04:57 PM Test Summary: 32427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7872

  17. Sybille Peters uploaded patch set 13 12/06/20, 18:00

  18. TYPO3com voted on patch set 13 V +1 12/06/20, 18:11 Completed build in 10m 14s on Sun, 6 Dec, 06:10 PM Test Summary: 32427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7874

  19. Sybille Peters uploaded patch set 14 12/14/20, 09:43

  20. TYPO3com voted on patch set 14 V -1 12/14/20, 09:43 Completed build in 20s on Mon, 14 Dec, 09:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8145

  21. Sybille Peters uploaded patch set 15 12/14/20, 09:54

  22. TYPO3com voted on patch set 15 V -1 12/14/20, 10:04 Completed build in 09m 34s on Mon, 14 Dec, 10:04 AM Test Summary: 1 of 32670 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8147

  23. TYPO3com voted on patch set 15 V +1 12/14/20, 11:26 Completed build in 08m 41s on Mon, 14 Dec, 11:26 AM Test Summary: 32429 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8151

  24. Sybille Peters commented on patch set 15 05/14/21, 14:12

    I have now implemented this feature in my extension "brofix" which is based on linkvalidator. This patch now has merge conflicts. I will not be working on this anymore.
  25. Sybille Peters abandoned the change 05/14/21, 14:12

    See note.