66612[TASK] Streamline usage of contrib packages in TypeScript
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
-
Verified V +2 Done
- Anja Leichsenring +2
- TYPO3com +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ColorPicker.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineSuggest.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ImageManipulation.ts+1 −1
- Build/types/TYPO3/index.d.ts+0 −5
- typo3/sysext/backend/Resources/Public/JavaScript/ColorPicker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineSuggest.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −0
- typo3/sysext/install/Resources/Public/JavaScript/RequireJSConfig.js+1 −1
Review log 611
-
Benjamin Franzke uploaded patch set 1 11/12/20, 09:25
-
Benjamin Franzke commented on patch set 1 11/12/20, 09:27
-
TYPO3com voted on patch set 1 V -1 11/12/20, 09:39 Completed build in 13m 45s on Thu, 12 Nov, 09:39 AM Test Summary: 3 of 75433 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-762
-
Benjamin Franzke uploaded patch set 2 11/12/20, 10:10
-
Benjamin Franzke commented on patch set 2 11/12/20, 10:12
ImmediateActionElement.ts:14ReplyHad to remove this change again, because the package document-register-element-polyfill would need to have been added to vendor/typo3/testing-framework/Resources/Core/Build/Configuration/JSUnit/Bootstrap.js – but only for v10. That's probably not worth it. -
TYPO3com voted on patch set 2 V -1 11/12/20, 10:21 Completed build in 11m 00s on Thu, 12 Nov, 10:21 AM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-763
-
TYPO3com commented on patch set 2 11/12/20, 13:10 Completed build in 12m 12s on Thu, 12 Nov, 01:10 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-764
-
TYPO3com commented on patch set 2 11/12/20, 14:47 Completed build in 2h 01m 06s on Thu, 12 Nov, 02:47 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-764
-
TYPO3com voted on patch set 2 V +1 11/13/20, 09:08 Completed build in 10m 57s on Fri, 13 Nov, 09:08 AM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-774
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 11/13/20, 10:38
-
Anja Leichsenring merged patch set 3 11/13/20, 10:38
ImmediateActionElement.ts:14