Review 10.4 Merged

66612[TASK] Streamline usage of contrib packages in TypeScript

Benjamin Franzke CR +2 V +2 Easy +8 −12 updated 11/13/20, 10:38

Commit message

No need to use a fully qualified namespace for
3rd party modules that are placed in TYPO3/CMS/Core/Contrib.
There are usually aliases configured in the requirejs configuration,
and if they are missing, we add them now.

This change additionally drops an unneded module declaration
for "TYPO3/CMS/Core/Contrib/imagesloaded.pkgd.min" which is
not needed when simply using "imagesloaded" as module name.

Commands used:

  grunt build

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 611

  1. Benjamin Franzke uploaded patch set 1 11/12/20, 09:25

  2. Benjamin Franzke commented on patch set 1 11/12/20, 09:27

    ImmediateActionElement.ts:14

    HEADS up: This one wasn't included in the master patch, as this polyfill only exists in v10. It is therefore added to the contrib lookup array in PageRenderer.
  3. TYPO3com voted on patch set 1 V -1 11/12/20, 09:39 Completed build in 13m 45s on Thu, 12 Nov, 09:39 AM Test Summary: 3 of 75433 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-762

  4. Benjamin Franzke uploaded patch set 2 11/12/20, 10:10

  5. Benjamin Franzke commented on patch set 2 11/12/20, 10:12

    ImmediateActionElement.ts:14 Reply

    Had to remove this change again, because the package document-register-element-polyfill would need to have been added to vendor/typo3/testing-framework/Resources/Core/Build/Configuration/JSUnit/Bootstrap.js – but only for v10. That's probably not worth it.
  6. TYPO3com voted on patch set 2 V -1 11/12/20, 10:21 Completed build in 11m 00s on Thu, 12 Nov, 10:21 AM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-763

  7. TYPO3com commented on patch set 2 11/12/20, 13:10 Completed build in 12m 12s on Thu, 12 Nov, 01:10 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-764

  8. TYPO3com commented on patch set 2 11/12/20, 14:47 Completed build in 2h 01m 06s on Thu, 12 Nov, 02:47 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-764

  9. TYPO3com voted on patch set 2 V +1 11/13/20, 09:08 Completed build in 10m 57s on Fri, 13 Nov, 09:08 AM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-774

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 11/13/20, 10:38

  11. Anja Leichsenring merged patch set 3 11/13/20, 10:38