66613[BUGFIX] Fix HTTP_HOST verification when HTTPS is proxied to HTTP
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1822
-
Benjamin Franzke uploaded patch set 1 11/12/20, 10:25
-
TYPO3com voted on patch set 1 V +1 11/12/20, 10:37 Completed build in 12m 14s on Thu, 12 Nov, 10:37 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7265
-
Benni Mack commented on patch set 1 11/12/20, 13:35
-
Benjamin Franzke uploaded patch set 2 05/11/21, 19:10
-
Benjamin Franzke commented on patch set 2 05/11/21, 19:10
GeneralUtility.php:2706Reply UnresolvedCurrently no adaption in NormalizedParams needed, as it (unfortunately) calls into GeneralUtility::isAllowedHostHeaderValue which then calls this method: https://github.com/TYPO3/TYPO3.CMS/blob/v11.2.0/typo3/sysext/core/Classes/Http/NormalizedParams.php#L588 -
core-ci voted on patch set 2 V -1 05/11/21, 19:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11397
-
Benjamin Franzke voted on patch set 2 CR -1 05/11/21, 19:44
-
Benjamin Franzke marked it work in progress 05/11/21, 19:45
-
Benjamin Franzke uploaded patch set 3 05/11/21, 20:16
-
core-ci voted on patch set 3 V +1 05/11/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11408
-
Benjamin Franzke commented on patch set 3 05/11/21, 20:28
This change is ready for review. -
Christian Kuhn commented on patch set 3 05/12/21, 12:50
Maybe unit-test this to nail the scenario? Those GeneralUtility methods have decent coverage, I guess it should be doable. -
Benjamin Franzke uploaded patch set 4 05/13/21, 09:33
-
Benjamin Franzke commented on patch set 4 05/13/21, 09:33
Reply
Ack & Done. -
core-ci voted on patch set 4 V +1 05/13/21, 09:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11471
-
Christian Kuhn voted on patch set 4 V +1 CR +1 05/13/21, 10:33
-
Benni Mack commented on patch set 4 05/18/21, 21:33
Do we need to fix this in NormalizedParams as well? -
Benjamin Franzke commented on patch set 4 05/19/21, 04:37
Reply
No, please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/66613/comment/7fa9a854_53677c38/ (and mark resolved if you agree) -
Benni Mack commented on patch set 4 05/19/21, 11:52
Reply
Hahaha. Sorry for this! -
Jochen Roth voted on patch set 4 V +1 CR +1 05/19/21, 13:34
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 05/19/21, 14:27
-
Benjamin Franzke merged patch set 5 05/19/21, 14:27
GeneralUtility.php:2706