Review main Merged

66620[BUGFIX] Ensure pageUid of RedirectFinisher can be parsed correctly

Elias Häußler CR +2 V +2 Normal +119 −2 updated 12/04/20, 15:00

Commit message

With #92112, parsing of the pageUid option of the RedirectFinisher has
been restricted to accept only strings as option value. Prior to this
change, one could also define integer values. The previous behavior has
now been restored by explicitly parsing the option value as string and
then parsing it back to an integer.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 68

  1. Elias Häußler uploaded patch set 1 11/12/20, 18:12

  2. Elias Häußler wrote 11/12/20, 18:17

    Topic set to ext:form
  3. TYPO3com voted on patch set 1 V +1 11/12/20, 18:25 Completed build in 12m 08s on Thu, 12 Nov, 06:25 PM Test Summary: 73653 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7274

  4. Elias Häußler updated the commit message in patch set 2 11/12/20, 18:26

  5. TYPO3com voted on patch set 2 V +1 11/12/20, 18:37 Completed build in 11m 01s on Thu, 12 Nov, 06:37 PM Test Summary: 73653 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7275

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 12/04/20, 13:54

  7. Daniel Goerz commented on patch set 2 V +2 CR +2 12/04/20, 15:00

    Thanks!
  8. Daniel Goerz merged patch set 3 12/04/20, 15:00