Review main Merged

66621[DOCS] Add examples how to create fallbacks for meta tags

TYPO3com CR +2 V +2 Normal +56 −0 updated 01/06/21, 10:01

Commit message

Added some more examples how to add fallbacks for specific metatags
when they are not rendered by EXT:seo.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. TYPO3com uploaded patch set 1 11/13/20, 09:45

  2. TYPO3com voted on patch set 1 V +1 11/13/20, 09:56 Completed build in 10m 39s on Fri, 13 Nov, 09:56 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7283

  3. Richard Haeser commented on patch set 1 CR -1 11/15/20, 18:47

    Part of the OG tags are rendered automatically when EXT:seo is installed so I don't think we should mention the fields that are already rendered by default. I will update the patch tomorrow.
  4. Oli Bartsch commented on patch set 1 01/05/21, 09:45

    > Patch Set 1: Code-Review-1 > > Part of the OG tags are rendered automatically when EXT:seo is installed so I don't think we should mention the fields that are already rendered by default. I will update the patch tomorrow. Hi Richard, will you continue here? Otherwise I could take care.
  5. Richard Haeser commented on patch set 1 01/05/21, 09:50

    Reply

    it is on my shortlist (for this week). but if you want to take over please go ahead.
  6. Oli Bartsch commented on patch set 1 01/05/21, 11:49

    Reply

    Looked into it and it seems like this is already a valid patch. og:descirption e.g. is only automatically added if the og_description field is filled. The patch author however wants to explain how og:description can be filled using the description field as a default and if it's empty use a static fallback text. This makes sense if one would like to ensure the og:description tag is always set. Either with a dedicated og_description value, the description field or with a static fallback text. What do you think?
  7. Richard Haeser commented on patch set 1 01/05/21, 13:19

    Reply

    Well, I really like the idea to show people how to add own data or (if you really want it) add fallbacks, but I do have some "comments" on this patch. The code snippet in this change, checks the title and description field and not the og:title and og:description field of the page properties (while the description said it is based on EXT:seo fields). The other thing is that you can argue if you want to add a fallback as all social networks have their own fallback to the title and description tag of a HTML page. If you don't set it specifically, they will find the best other option starting with the title and description. So I would suggest to add that info to this docs to make sure your DOM will not be larger as strictly needed. By not setting a specific og title / description you will also say to the social network: "I don't have a specific title and description for you, so please check what is best for this user". Which is basically what you want if you do not set the title and description manually IMHO. Basically the only thing why you would add those tags with fallbacks to other fields is to get green checkboxes on validators, and I have an opinion on that :P
  8. Oli Bartsch commented on patch set 1 01/05/21, 16:35

    Reply

    All right. I don't have a strong opinion on it. Just tried to understand the authors intention. Please feel free to adjust and ping me once it can be reviewed :)
  9. Richard Haeser uploaded patch set 2 01/05/21, 23:16

  10. TYPO3com voted on patch set 2 V +1 01/05/21, 23:32 Completed build in 12m 37s on Tue, 5 Jan, 11:32 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8663

  11. Richard Haeser uploaded patch set 3 01/06/21, 08:03

  12. TYPO3com voted on patch set 3 V +1 01/06/21, 08:13 Completed build in 10m 05s on Wed, 6 Jan, 08:13 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8671

  13. Jörg Bösche voted on patch set 3 V +1 CR +1 01/06/21, 09:30

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 01/06/21, 10:01

  15. Christian Kuhn merged patch set 4 01/06/21, 10:01