Review main Merged

66622[BUGFIX] Install tool database row updater works with mssql

Christian Kuhn CR +2 V +2 Easy +15 −4 updated 11/13/20, 19:54

Commit message

SqlServer can not handle a transaction for a table, if the
same table is queried currently. The install tool database
row updater does this. Solution is to skip the transaction
on this platform. Additionally, an update query is fixed
to hint for proper field types.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 11/13/20, 13:15

  2. TYPO3com voted on patch set 1 V +1 11/13/20, 13:26 Completed build in 11m 12s on Fri, 13 Nov, 01:26 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7285

  3. Andreas Kienast voted on patch set 1 CR +1 11/13/20, 14:23

  4. Benni Mack voted on patch set 1 V +1 CR +1 11/13/20, 16:51

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/13/20, 19:13

  6. Benni Mack voted on patch set 1 V +2 CR +2 11/13/20, 19:54

  7. Benni Mack merged patch set 2 11/13/20, 19:54