Review main Merged

66624[TASK] Streamline server response check

Oliver Hader CR +2 V +2 Hard +226 −93 updated 11/13/20, 17:28

Commit message

* replace string states with specific StatusMessage models
* combine file path and base URL in new FileLocation model
* streamline responsibilities of classes

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 58

  1. Oliver Hader uploaded patch set 1 11/13/20, 16:31

  2. Oliver Hader rebased onto patch set 2 11/13/20, 16:44

  3. TYPO3com voted on patch set 1 V +1 11/13/20, 16:45 Completed build in 13m 40s on Fri, 13 Nov, 04:45 PM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7287

  4. Oliver Hader rebased onto patch set 3 11/13/20, 16:52

  5. TYPO3com voted on patch set 2 V +1 11/13/20, 16:57 Completed build in 12m 59s on Fri, 13 Nov, 04:57 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7288

  6. TYPO3com voted on patch set 3 V +1 11/13/20, 17:06 Completed build in 13m 44s on Fri, 13 Nov, 05:06 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7289

  7. Oliver Hader voted on patch set 3 V +2 CR +2 11/13/20, 17:27

  8. Oliver Hader merged patch set 4 11/13/20, 17:28