Review main Merged

66627[TASK] Introduce resource Content-Security-Policy check

Oliver Hader CR +2 V +2 Hard +325 −1 updated 11/16/20, 16:52

Commit message

Introduces Content-Security-Policy HTTP header check on
fileadmin/ resources.

This can be seen as follow-up up to TYPO3-CORE-SA-2020-006
and TYPO3-PSA-2019-010 now actively analyzing this HTTP
header and letting users know in reports module and
system environment check of the Install Tool.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1927

Show 12 earlier messages
  1. Oliver Hader uploaded patch set 1 11/13/20, 17:31

  2. TYPO3com voted on patch set 1 V -1 11/13/20, 17:32 Completed build in 21s on Fri, 13 Nov, 05:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7290

  1. Oliver Hader uploaded patch set 2 11/13/20, 17:33

  2. TYPO3com voted on patch set 2 V -1 11/13/20, 17:47 Completed build in 13m 43s on Fri, 13 Nov, 05:46 PM Test Summary: 73671 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7291

  3. Markus Klein updated the commit message in patch set 3 11/13/20, 21:57

  4. Markus Klein commented on patch set 3 11/13/20, 22:02

    ContentSecurityPolicyDirective.php:60

    lets skip those phpdoc as they do not convey more meaning

    resources-root-htaccess:1

    applies
  5. TYPO3com voted on patch set 3 V -1 11/13/20, 22:17 Completed build in 15m 20s on Fri, 13 Nov, 10:17 PM Test Summary: 73683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7297

  6. Oliver Hader commented on patch set 3 11/14/20, 09:11

    ContentSecurityPolicyDirective.php:60 Reply

    Ack

    resources-root-htaccess:1 Reply

    Ack
  7. Oliver Hader uploaded patch set 4 11/14/20, 09:12

  8. TYPO3com voted on patch set 4 V -1 11/14/20, 09:23 Completed build in 11m 20s on Sat, 14 Nov, 09:23 AM Test Summary: 1 of 74168 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7298

  9. TYPO3com voted on patch set 4 V +1 11/14/20, 09:44 Completed build in 43m 06s on Sat, 14 Nov, 09:44 AM Test Summary: 73683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7298

  10. Markus Klein voted on patch set 4 CR +1 11/16/20, 10:29

  11. Georg Ringer voted on patch set 4 V +1 CR +1 11/16/20, 12:18

  12. Oliver Hader voted on patch set 4 CR -1 11/16/20, 12:43

  13. Oliver Hader commented on patch set 4 11/16/20, 12:47

    During writing documentation for CoreAPI I realized style-src and object-src should be integrated as well
  14. Oliver Hader commented on patch set 4 11/16/20, 12:55

  15. Oliver Hader uploaded patch set 5 11/16/20, 13:03

  16. Oliver Hader uploaded patch set 6 11/16/20, 13:06

  17. Oliver Hader commented on patch set 6 CR -1 11/16/20, 13:08

    ...
  18. Oliver Hader uploaded patch set 7 11/16/20, 13:09

  19. Oliver Hader commented on patch set 7 11/16/20, 13:13

    okay... (hopefully) done now
  20. TYPO3com voted on patch set 5 V +1 11/16/20, 13:24 Completed build in 20m 16s on Mon, 16 Nov, 01:24 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7343

  21. TYPO3com voted on patch set 7 V +1 11/16/20, 13:32 Completed build in 15m 18s on Mon, 16 Nov, 01:32 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7346

  22. TYPO3com voted on patch set 6 V +1 11/16/20, 13:43 Completed build in 26m 06s on Mon, 16 Nov, 01:43 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7345

  23. Markus Klein voted on patch set 7 V +1 CR +1 11/16/20, 15:45

  24. Oliver Hader voted on patch set 7 V +2 CR +2 11/16/20, 16:52

  25. Oliver Hader merged patch set 8 11/16/20, 16:52