Review 9.5 Merged

66629[TASK] Introduce resource Content-Security-Policy check

Oliver Hader CR +2 V +2 Hard +325 −1 updated 11/16/20, 16:52

Commit message

Introduces Content-Security-Policy HTTP header check on
fileadmin/ resources.

This can be seen as follow-up up to TYPO3-CORE-SA-2020-006
and TYPO3-PSA-2019-010 now actively analyzing this HTTP
header and letting users know in reports module and
system environment check of the install tool.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 813

  1. Oliver Hader uploaded patch set 1 11/13/20, 17:38

  2. TYPO3com voted on patch set 1 V -1 11/13/20, 17:44 Completed build in 39s on Fri, 13 Nov, 05:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-889

  3. Oliver Hader uploaded patch set 2 11/14/20, 09:14

  4. Oliver Hader uploaded patch set 3 11/14/20, 09:15

  5. TYPO3com commented on patch set 2 11/14/20, 09:19 Completed build in 21s on Sat, 14 Nov, 09:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-890

  6. TYPO3com voted on patch set 3 V -1 11/14/20, 09:20 Completed build in 32s on Sat, 14 Nov, 09:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-891

  7. Oliver Hader commented on patch set 3 11/14/20, 09:39

    ``` -declare(strict_types=1); +declare(strict_types = 1); ``` I think I've wasted days already with these kind of "CGL" compliances... :D
  8. Oliver Hader uploaded patch set 4 11/14/20, 09:40

  9. TYPO3com voted on patch set 4 V +1 11/14/20, 09:55 Completed build in 14m 30s on Sat, 14 Nov, 09:55 AM Test Summary: 75258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-892

  10. Oliver Hader uploaded patch set 5 11/16/20, 13:12

  11. TYPO3com voted on patch set 5 V +1 11/16/20, 13:37 Completed build in 20m 25s on Mon, 16 Nov, 01:37 PM Test Summary: 75264 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-896

  12. Oliver Hader voted on patch set 5 V +2 CR +2 11/16/20, 16:52

  13. Oliver Hader merged patch set 6 11/16/20, 16:52