Review main Merged Breaking

66632[!!!][TASK] Drop workspace additional services

Christian Kuhn CR +2 V +2 Hard +59 −320 updated 11/14/20, 18:44

Commit message

Back in 6.2 at ExtJS times, a feature has been introduced
to the workspace module to extend the shown 'data grid'
with custom columns. This implementation has been done for
one specific customer who nowadays does not use the feature
anymore.
The feature broke when the transition to a native JavaScript
implementation has been done in v8. There is not a single bug
report this feature broke in forge, and it is hard to resurrect
it with the new client side implementation.
The patch drops related code from the extension. This gives
core development more freedom to improve the workspace module
with other patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 56

  1. Christian Kuhn uploaded patch set 1 11/14/20, 10:53

  2. TYPO3com voted on patch set 1 V +1 11/14/20, 11:04 Completed build in 10m 56s on Sat, 14 Nov, 11:04 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7303

  3. Daniel Haupt voted on patch set 1 V +1 CR +1 11/14/20, 14:55

  4. Benni Mack voted on patch set 1 CR +2 11/14/20, 18:44

  5. Benni Mack voted on patch set 1 V +2 11/14/20, 18:44

  6. Benni Mack merged patch set 2 11/14/20, 18:44