Review 10.4 Merged

66633[TASK] Introduce sudo mode for install tool accessed via backend

Oliver Hader CR +2 V +2 Hard +455 −20 updated 11/16/20, 15:19

Commit message

The session expiration time for the install tool is reduced from
60 to 15 minutes. When accessing the install tool via backend user
interface, current logged in backend users have to confirm their
user password again in order to get access to the install tool.
This process is known as "sudo mode".

Standalone install tool is not affected by sudo mode confirmation.
This change enforces mitigation as mentioned in TYPO3-CORE-SA-2020-006,
see https://typo3.org/security/advisory/typo3-core-sa-2020-006.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1422

  1. Oliver Hader uploaded patch set 1 11/14/20, 12:46

  2. TYPO3com voted on patch set 1 V -1 11/14/20, 12:58 Completed build in 11m 05s on Sat, 14 Nov, 12:58 PM Test Summary: 3 of 75554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-780

  3. TYPO3com commented on patch set 1 11/14/20, 13:05 Completed build in 30m 00s on Sat, 14 Nov, 01:05 PM Test Summary: 3 of 75554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-780

  4. Oliver Hader commented on patch set 1 11/14/20, 14:06

    I failed to understand why acceptance tests are working in v9 and master, but not in v10... giving up
  5. Oliver Hader uploaded patch set 2 11/14/20, 15:04

  6. Oliver Hader commented on patch set 2 11/14/20, 15:06

    v9 used different tests - unsure why master did not fail
  7. TYPO3com voted on patch set 2 V +1 11/14/20, 15:19 Completed build in 14m 32s on Sat, 14 Nov, 03:19 PM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-781

  8. Oliver Hader commented on patch set 2 CR -1 11/15/20, 12:32

    See comments in master change
  9. Oliver Hader uploaded patch set 3 11/16/20, 10:04

  10. Oliver Hader voted on patch set 3 CR -1 11/16/20, 10:15

  11. TYPO3com voted on patch set 3 V -1 11/16/20, 10:20 Completed build in 15m 49s on Mon, 16 Nov, 10:20 AM Test Summary: 3 of 75554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-786

  12. Oliver Hader uploaded patch set 4 11/16/20, 10:31

  13. TYPO3com voted on patch set 4 V -1 11/16/20, 10:43 Completed build in 11m 33s on Mon, 16 Nov, 10:43 AM Test Summary: 3 of 75554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-787

  14. Oliver Hader uploaded patch set 5 11/16/20, 10:57

  15. TYPO3com voted on patch set 5 V +1 11/16/20, 11:12 Completed build in 13m 03s on Mon, 16 Nov, 11:12 AM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-789

  16. Oliver Hader uploaded patch set 6 11/16/20, 11:37

  17. TYPO3com voted on patch set 6 V +1 11/16/20, 11:57 Completed build in 19m 33s on Mon, 16 Nov, 11:57 AM Test Summary: 75065 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-790

  18. Georg Ringer uploaded patch set 7 11/16/20, 13:46

  19. Oliver Hader voted on patch set 7 CR +1 11/16/20, 14:08

  20. TYPO3com voted on patch set 7 V +1 11/16/20, 14:13 Completed build in 16m 53s on Mon, 16 Nov, 02:13 PM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-793

  21. Oliver Hader voted on patch set 7 V +2 CR +2 11/16/20, 15:19

  22. Oliver Hader merged patch set 8 11/16/20, 15:19