Review 9.5 Merged

66634[TASK] Introduce sudo mode for install tool accessed via backend

Oliver Hader CR +2 V +2 Hard +432 −13 updated 11/16/20, 15:21

Commit message

The session expiration time for the install tool is reduced from
60 to 15 minutes. When accessing the install tool via backend user
interface, currently logged in backend users have to confirm their
user password again in order to get access to the install tool.
This process is known as "sudo mode".

Standalone install tool is not affected by sudo mode confirmation.
This change enforces mitigation as mentioned in TYPO3-CORE-SA-2020-006,
see https://typo3.org/security/advisory/typo3-core-sa-2020-006.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 913

  1. Oliver Hader uploaded patch set 1 11/14/20, 12:54

  2. TYPO3com voted on patch set 1 V +1 11/14/20, 13:06 Completed build in 12m 37s on Sat, 14 Nov, 01:06 PM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-893

  3. Oliver Hader commented on patch set 1 11/15/20, 12:32

    See comments in master change
  4. Oliver Hader voted on patch set 1 CR -1 11/15/20, 12:40

  5. Oliver Hader uploaded patch set 2 11/16/20, 10:29

  6. TYPO3com voted on patch set 2 V +1 11/16/20, 10:43 Completed build in 13m 58s on Mon, 16 Nov, 10:43 AM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-894

  7. Oliver Hader uploaded patch set 3 11/16/20, 11:38

  8. TYPO3com voted on patch set 3 V +1 11/16/20, 12:03 Completed build in 17m 38s on Mon, 16 Nov, 12:03 PM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-895

  9. Georg Ringer uploaded patch set 4 11/16/20, 14:03

  10. Oliver Hader voted on patch set 4 CR +1 11/16/20, 14:09

  11. TYPO3com voted on patch set 4 V +1 11/16/20, 14:25 Completed build in 14m 36s on Mon, 16 Nov, 02:25 PM Test Summary: 75198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-898

  12. Oliver Hader voted on patch set 4 V +2 CR +2 11/16/20, 15:20

  13. Oliver Hader merged patch set 5 11/16/20, 15:21