Review main Merged Breaking

66640[!!!][TASK] Remove lockToIP UserTsConfig flag

Benni Mack CR +2 V +2 Normal +84 −51 updated 11/26/20, 21:04

Commit message

The UserTsConfig setting `options.lockToIP` is
removed, which was only active the global setting
$GLOBALS['TYPO3_CONF_VARS']['BE']['enabledBeUserIPLock']
was active.

Happy Eyeballs makes this feature very useless, but if
this is still needed, it should be rather implemented
as an individual AuthenticationService or PSR-15 middleware
than evaluated separately.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 811

  1. Benni Mack uploaded patch set 1 11/16/20, 10:21

  2. TYPO3com voted on patch set 1 V +1 11/16/20, 10:33 Completed build in 12m 17s on Mon, 16 Nov, 10:33 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7334

  3. Benni Mack updated the commit message in patch set 2 11/26/20, 12:52

  4. TYPO3com voted on patch set 2 V +1 11/26/20, 13:09 Completed build in 11m 54s on Thu, 26 Nov, 01:09 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7596

  5. Benni Mack uploaded patch set 3 11/26/20, 16:16

  6. TYPO3com voted on patch set 3 V +1 11/26/20, 16:28 Completed build in 11m 01s on Thu, 26 Nov, 04:28 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7610

  7. Georg Ringer voted on patch set 3 V +1 CR +1 11/26/20, 17:29

  8. Daniel Haupt voted on patch set 3 V +1 CR +1 11/26/20, 18:55

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 11/26/20, 20:26

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/26/20, 21:04

  11. Benni Mack merged patch set 4 11/26/20, 21:04