Review main Merged

66641[TASK] Use PageRenderer hooks in t3editor and rte_ckeditor

Christian Kuhn CR +2 V +2 Normal +102 −31 updated 11/16/20, 15:12

Commit message

Instead of instantiating PageRenderer early in
ext_localconf, the additional require js for
t3editor and rte_ckeditor is now injected by a
PageRenderer hook when needed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1

Issues 1

Files 4

Review log 913

  1. Christian Kuhn uploaded patch set 1 11/16/20, 12:10

  2. TYPO3com voted on patch set 1 V -1 11/16/20, 12:10 Completed build in 20s on Mon, 16 Nov, 12:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7338

  3. Benni Mack commented on patch set 1 11/16/20, 12:59

    please mark both classes as internal and final, since they are not part of the TYPO3 API.
  4. Christian Kuhn commented on patch set 1 11/16/20, 13:01

    > Patch Set 1: > > please mark both classes as internal and final, since they are not part of the TYPO3 API. ack
  5. Christian Kuhn uploaded patch set 2 11/16/20, 13:01

  6. Christian Kuhn uploaded patch set 3 11/16/20, 13:02

  7. TYPO3com voted on patch set 2 V +1 11/16/20, 13:14 Completed build in 12m 13s on Mon, 16 Nov, 01:14 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7341

  8. TYPO3com voted on patch set 3 V +1 11/16/20, 13:19 Completed build in 15m 28s on Mon, 16 Nov, 01:19 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7342

  9. Oli Bartsch uploaded patch set 4 11/16/20, 14:57

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 11/16/20, 14:57

  11. Benni Mack voted on patch set 4 V +2 CR +2 11/16/20, 15:06

  12. Benni Mack merged patch set 5 11/16/20, 15:06

  13. TYPO3com voted on patch set 4 V +1 11/16/20, 15:12 Completed build in 14m 19s on Mon, 16 Nov, 03:12 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7355