66642[TASK] Make ActionController abstract
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 79
-
Alexander Schnitzler uploaded patch set 1 11/16/20, 13:22
-
Alexander Schnitzler wrote 11/16/20, 13:22
Topic set to extbase -
TYPO3com voted on patch set 1 V -1 11/16/20, 13:52 Completed build in 15m 30s on Mon, 16 Nov, 01:52 PM Test Summary: 1 of 74108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7347
-
TYPO3com voted on patch set 1 V +1 11/16/20, 14:14 Completed build in 52m 23s on Mon, 16 Nov, 02:14 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7347
-
Christian Kuhn voted on patch set 1 V +1 CR +1 11/16/20, 14:14
-
Benni Mack commented on patch set 1 11/16/20, 15:39
shouldn't an abstract class contain at least one abstract method? -
Alexander Schnitzler commented on patch set 1 11/16/20, 16:12
> Patch Set 1: > > shouldn't an abstract class contain at least one abstract method? I wouldn't say so. The most important trait of abstract classes is their inability to be instantiated. Abstract methods are a plus, but not a must have since the api is defined by interfaces. btw: https://github.com/symfony/symfony/blob/5.x/src/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.php -
Benni Mack voted on patch set 1 V +2 CR +2 11/16/20, 20:28
-
Benni Mack merged patch set 2 11/16/20, 20:28