Review main Merged

66643[TASK] Correct role in feature rst

Chris Müller CR +2 V +2 Easy +1 −1 updated 11/16/20, 14:31

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Chris Müller uploaded patch set 1 11/16/20, 13:24

  2. TYPO3com voted on patch set 1 V -1 11/16/20, 14:03 Completed build in 26m 30s on Mon, 16 Nov, 02:03 PM Test Summary: 73611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7349

  3. Mathias Brodala commented on patch set 1 11/16/20, 14:05

    Feature-92531-ImprovedEmailValidation.rst:12

    We should also use validEmail() here while we're at it to clearly show that this is a method, not a constant.
  4. Christian Kuhn commented on patch set 1 V +1 CR +1 11/16/20, 14:05

    will merge if green.
  5. Christian Kuhn commented on patch set 1 V 0 CR 0 11/16/20, 14:06

    Feature-92531-ImprovedEmailValidation.rst:12 Reply

    Ack
  6. Christian Kuhn uploaded patch set 2 11/16/20, 14:07

  7. Mathias Brodala voted on patch set 2 CR +1 11/16/20, 14:08

  8. TYPO3com voted on patch set 1 V +1 11/16/20, 14:15 Completed build in 1h 04m 19s on Mon, 16 Nov, 02:14 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7349

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 11/16/20, 14:16

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 11/16/20, 14:19

  11. TYPO3com voted on patch set 2 V +1 11/16/20, 14:31 Completed build in 20m 27s on Mon, 16 Nov, 02:31 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7351

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 11/16/20, 14:31

  13. Christian Kuhn merged patch set 3 11/16/20, 14:31