Review main Merged Breaking

66644[!!!][TASK] Remove method canProcessRequest

Alexander Schnitzler CR +2 V +2 Normal +68 −77 updated 11/23/20, 07:50

Commit message

With this patch method canProcessRequest() of class
\TYPO3\CMS\Extbase\Mvc\Controller\ActionController has
been removed because it could never fulfill its claim,
enabling users to simply register custom request types
and then have custom controllers be built and dispatched
depending on the request type.

Besides that, dispatching another controller than the one
configured and requested is unwanted behaviour.

Furthermore, the corresponding protected property
$supportedRequestTypes and the UnsupportedRequestTypeException
have also been removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Tizian Schmidlin +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Tizian Schmidlin +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2125

  1. Alexander Schnitzler uploaded patch set 1 11/16/20, 14:27

  2. TYPO3com voted on patch set 1 V +1 11/16/20, 14:47 Completed build in 17m 22s on Mon, 16 Nov, 02:47 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7352

  3. Alexander Schnitzler commented on patch set 1 11/16/20, 14:49

    This change is ready for review.
  4. Alexander Schnitzler wrote 11/16/20, 14:49

    Topic set to extbase
  5. Oliver Klee commented on patch set 1 11/16/20, 15:22

    ActionController.php:389

    This line than probably should be removed as well.
  6. Alexander Schnitzler commented on patch set 1 11/16/20, 15:25

    ActionController.php:389 Reply Unresolved

    Yes, good catch.
  7. Benni Mack commented on patch set 1 CR +1 11/16/20, 15:41

    totally in line with this change. The main reason for this behavior originally was btw the functionality of a "Web Request" vs. "CLI Request" and the RequestInterface, which does not make sense anymore since TYPO3 v9. Should we update the RST explaining the reasoning as well? I could take care of it.
  8. Alexander Schnitzler commented on patch set 1 11/16/20, 16:13

    > Patch Set 1: Code-Review+1 > > totally in line with this change. The main reason for this behavior originally was btw the functionality of a "Web Request" vs. "CLI Request" and the RequestInterface, which does not make sense anymore since TYPO3 v9. > > Should we update the RST explaining the reasoning as well? I could take care of it. That would be nice.
  9. Benni Mack commented on patch set 2 11/16/20, 20:25

    Published edit on patch set 1.
  10. Benni Mack voted on patch set 2 V +1 CR +1 11/16/20, 20:25

  11. Benni Mack commented on patch set 3 11/16/20, 20:27

    Published edit on patch set 2.
  12. Benni Mack voted on patch set 3 V +1 CR +1 11/16/20, 20:27

  13. TYPO3com voted on patch set 2 V +1 11/16/20, 20:40 Completed build in 14m 36s on Mon, 16 Nov, 08:40 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7365

  14. TYPO3com voted on patch set 3 V +1 11/16/20, 20:46 Completed build in 16m 17s on Mon, 16 Nov, 08:46 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7366

  15. Oli Bartsch commented on patch set 3 CR -1 11/17/20, 14:59

    There are still a couple of places where the @throws annotation is present while the exception is now not longer thrown (ControllerInterface, PasswordRecoveryController, AdministrationController). They should be removed there, too. Maybe we could also completely remove the UnsupportedRequestTypeException since it was the only usage in core. This would however be another breaking change if 3rd party is using it in their code.

    ControllerInterface.php:39 Unresolved

    Will never be thrown.
  16. Oli Bartsch uploaded patch set 4 11/20/20, 16:24

  17. Oli Bartsch voted on patch set 4 V +1 CR +1 11/20/20, 16:25

  18. TYPO3com voted on patch set 4 V +1 11/20/20, 16:50 Completed build in 16m 33s on Fri, 20 Nov, 04:50 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7487

  19. Tizian Schmidlin commented on patch set 4 11/20/20, 17:10

    Should I take the chance from this MR to https://review.typo3.org/c/Packages/TYPO3.CMS/+/64790 since there seems to be a merge conflict on the AdministrationController.php? Or how could we properly fix this MR? I tried to look at my changes but I really don't see what clashes here.
  20. Benni Mack commented on patch set 4 11/20/20, 17:30

    I suggest we'll get this one in, and then resolve the merge conflict on the other one, OK Tizian?
  21. Georg Ringer voted on patch set 4 V +2 CR +2 11/20/20, 19:44

  22. Georg Ringer merged patch set 5 11/20/20, 19:44

  23. Tizian Schmidlin commented on patch set 5 11/23/20, 07:50

    > Patch Set 4: > > I suggest we'll get this one in, and then resolve the merge conflict on the other one, OK Tizian? Yep, it seems that merging this change to master solved the merge conflict, somehow.
  24. Tizian Schmidlin commented on patch set 5 11/23/20, 07:50

    > Patch Set 4: > > I suggest we'll get this one in, and then resolve the merge conflict on the other one, OK Tizian? Yep, it seems that merging this change to master solved the merge conflict, somehow.
  25. Tizian Schmidlin commented on patch set 5 V +1 CR +1 11/23/20, 07:50

    > Patch Set 4: > > I suggest we'll get this one in, and then resolve the merge conflict on the other one, OK Tizian? Yep, it seems that merging this change to master solved the merge conflict, somehow.