Review main Merged

66664[SECURITY] Protect persisted session IDs from being used directly

Oliver Hader CR +2 V +2 Normal +169 −44 updated 01/14/21, 08:35

Commit message

Instead of storing session IDs with their corresponding storage
backends in plain text, their HMAC-SHA256 (Redis) or HMAC-MD5 (DB)
is being used. HMAC-MD5 had to be chosen to avoid breaking changes
for limited field size in database fields (32 characters currently).

This change also allows a fallback to non-hashed-session values,
meaning that
* set() and update() will create new session records with the hashed
  identifier
* get() contains a fallback to the non-hashed-version when no session
  with a hashed identifier is found

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 13

Review log 56

  1. Oliver Hader uploaded patch set 1 11/17/20, 08:51

  2. Oliver Hader commented on patch set 1 V +2 CR +2 11/17/20, 08:51

    Auto-approved
  3. Oliver Hader merged patch set 2 11/17/20, 08:51

  4. TYPO3com voted on patch set 1 V +1 11/17/20, 09:38 Completed build in 42m 01s on Tue, 17 Nov, 09:38 AM Test Summary: 73692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7375

  5. Christian Kuhn commented on patch set 2 12/21/20, 17:28

  6. Oliver Hader commented on patch set 2 01/14/21, 08:35

    AbstractUserAuthentication.php:697 Reply

    Ack