66664[SECURITY] Protect persisted session IDs from being used directly
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
Issues 1
Files 13
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+2 −2
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php2+12 −0
- typo3/sysext/core/Classes/Session/Backend/DatabaseSessionBackend.php+40 −8
- typo3/sysext/core/Classes/Session/Backend/HashableSessionBackendInterface.phpnew+23 −0
- typo3/sysext/core/Classes/Session/Backend/RedisSessionBackend.php+30 −12
- typo3/sysext/core/Classes/Session/SessionManager.php+10 −3
- typo3/sysext/core/Tests/Acceptance/Fixtures/be_sessions.xmlnew+21 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Extension/PageTreeCoreEnvironment.php+1 −1
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Session/SessionManagerTest.php+17 −12
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+6 −3
Review log 56
-
Oliver Hader uploaded patch set 1 11/17/20, 08:51
-
Oliver Hader commented on patch set 1 V +2 CR +2 11/17/20, 08:51
Auto-approved -
Oliver Hader merged patch set 2 11/17/20, 08:51
-
TYPO3com voted on patch set 1 V +1 11/17/20, 09:38 Completed build in 42m 01s on Tue, 17 Nov, 09:38 AM Test Summary: 73692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7375
-
Christian Kuhn commented on patch set 2 12/21/20, 17:28
AbstractUserAuthentication.php:697has been handled in v11 / master with https://review.typo3.org/c/Packages/TYPO3.CMS/+/66935/56/typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php#b667 -
Oliver Hader commented on patch set 2 01/14/21, 08:35
AbstractUserAuthentication.php:697ReplyAck