Review main Merged

66671[BUGFIX] Make non-visible l10n_parent fields of type group

Markus Klein CR +2 V +2 Easy +12 −14 updated 11/20/20, 12:46

Commit message

The l10n_parent fields of sys_file_metadata and sys_file_reference are
never shown anywhere. Having them as type 'select' in the TCA causes the
FormEngine to try loading all possible parent value, which can be
thousands or more. This degrades backend performance towards unusable.

Changing the TCA definition to 'group' mitigates the issue easily as no
lookup list has to be created/loaded.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Torben Hansen +1
    • Christian Kuhn +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Markus Klein uploaded patch set 1 11/17/20, 19:30

  2. Markus Klein uploaded patch set 2 11/17/20, 19:31

  3. Wouter Wolters voted on patch set 2 CR +1 11/17/20, 19:34

  4. TYPO3com voted on patch set 1 V +1 11/17/20, 19:43 Completed build in 13m 07s on Tue, 17 Nov, 07:43 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7381

  5. TYPO3com voted on patch set 2 V -1 11/17/20, 19:50 Completed build in 15m 56s on Tue, 17 Nov, 07:50 PM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7382

  6. TYPO3com voted on patch set 2 V +1 11/17/20, 20:13 Completed build in 14m 16s on Tue, 17 Nov, 08:13 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7385

  7. Torben Hansen voted on patch set 2 CR +1 11/18/20, 06:50

  8. Mathias Brodala commented on patch set 2 V +1 CR +1 11/18/20, 07:29

    This is the same pattern we usually use to avoid issues like this.
  9. Christian Kuhn voted on patch set 2 CR +1 11/18/20, 09:56

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 11/20/20, 12:46

  11. Anja Leichsenring merged patch set 3 11/20/20, 12:46