66692[TASK] Use PreviewRenderer instead of PageLayoutView hooks
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+58 −77
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php1+10 −3
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+1 −0
- typo3/sysext/form/ext_localconf.php+0 −4
- typo3/sysext/frontend/Classes/Hooks/PageLayoutView/ImagePreviewRenderer.php1deleted+0 −69
- typo3/sysext/frontend/Classes/Hooks/PageLayoutView/TextmediaPreviewRenderer.phpdeleted+0 −73
- typo3/sysext/frontend/Classes/Hooks/PageLayoutView/TextpicPreviewRenderer.phpdeleted+0 −73
- typo3/sysext/frontend/Classes/Hooks/PageLayoutView/TextPreviewRenderer.phpdeleted+0 −51
- typo3/sysext/frontend/Classes/Preview/ImagePreviewRenderer.phpnew+51 −0
- typo3/sysext/frontend/Classes/Preview/TextmediaPreviewRenderer.phpnew+57 −0
- typo3/sysext/frontend/Classes/Preview/TextpicPreviewRenderer.phpnew+58 −0
- typo3/sysext/frontend/Classes/Preview/TextPreviewRenderer.phpnew+34 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+4 −0
- typo3/sysext/frontend/ext_localconf.php+0 −10
Review log 2031
Show 36 earlier messages
-
Georg Ringer uploaded patch set 1 11/17/20, 19:53
-
TYPO3com voted on patch set 1 V -1 11/17/20, 19:53 Completed build in 21s on Tue, 17 Nov, 07:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7383
-
Georg Ringer uploaded patch set 2 11/17/20, 19:54
-
TYPO3com voted on patch set 2 V -1 11/17/20, 20:07 Completed build in 12m 38s on Tue, 17 Nov, 08:07 PM Test Summary: 8 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7384
-
Georg Ringer uploaded patch set 3 11/17/20, 20:44
-
TYPO3com voted on patch set 3 V -1 11/17/20, 20:57 Completed build in 12m 30s on Tue, 17 Nov, 08:57 PM Test Summary: 6 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7386
-
Georg Ringer uploaded patch set 4 11/17/20, 21:11
-
Georg Ringer uploaded patch set 5 11/17/20, 21:11
-
TYPO3com voted on patch set 4 V -1 11/17/20, 21:11 Completed build in 25s on Tue, 17 Nov, 09:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7387
-
Georg Ringer uploaded patch set 6 11/17/20, 21:19
-
TYPO3com voted on patch set 5 V -1 11/17/20, 21:24 Completed build in 12m 52s on Tue, 17 Nov, 09:24 PM Test Summary: 6 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7388
-
TYPO3com voted on patch set 6 V -1 11/17/20, 21:32 Completed build in 13m 21s on Tue, 17 Nov, 09:32 PM Test Summary: 6 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7389
-
Georg Ringer rebased onto patch set 7 11/24/20, 17:28
-
Georg Ringer uploaded patch set 8 11/24/20, 17:37
-
Georg Ringer commented on patch set 8 11/24/20, 17:37
This change is ready for review. -
TYPO3com voted on patch set 7 V -1 11/24/20, 17:40 Completed build in 11m 28s on Tue, 24 Nov, 05:40 PM Test Summary: 6 of 32632 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7549
-
TYPO3com voted on patch set 8 V -1 11/24/20, 17:49 Completed build in 11m 57s on Tue, 24 Nov, 05:49 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7550
-
Georg Ringer uploaded patch set 9 11/24/20, 18:01
-
TYPO3com voted on patch set 9 V +1 11/24/20, 18:12 Completed build in 10m 48s on Tue, 24 Nov, 06:12 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7553
-
Claus Due commented on patch set 9 CR +1 11/25/20, 10:22
RenderContentElementPreviewViewHelper.php:37I would consider dropping this ViewHelper instead (previewing a record is specific to the page module where we should have the ColumnItem->getPreview() method available always) - but this can just as well be done in a followup patch. I'm assuming non-breaking since marked @internal. -
Tymoteusz Motylewski commented on patch set 9 11/25/20, 15:54
ImagePreviewRenderer.php:18Unresolvedshouldn't the namespace also change to sth different than hooks ? -
Georg Ringer uploaded patch set 10 12/01/20, 22:29
-
TYPO3com voted on patch set 10 V +1 12/01/20, 22:38 Completed build in 09m 28s on Tue, 1 Dec, 10:38 PM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7740
-
Benni Mack commented on patch set 10 V +1 12/06/20, 16:17
nice one. works just as expected. I also agree about the namespace, would you be OK to move this to Classes/ContentPreview instead? -
Benni Mack uploaded patch set 11 12/07/20, 06:55
-
TYPO3com voted on patch set 11 V +1 12/07/20, 07:04 Completed build in 08m 53s on Mon, 7 Dec, 07:04 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7881
-
Benni Mack voted on patch set 11 V +1 CR +1 12/08/20, 11:46
-
Georg Ringer voted on patch set 11 V +1 CR +1 12/08/20, 18:19
-
Oli Bartsch voted on patch set 11 V +1 CR +1 12/08/20, 18:58
-
Benni Mack voted on patch set 11 V +2 CR +2 12/08/20, 21:19
-
Benni Mack merged patch set 12 12/08/20, 21:19