Review main Merged

66696[BUGFIX] Update sessions in RedisBackend correctly

Markus Klein CR +2 V +2 Easy +35 −5 updated 11/25/20, 12:58

Commit message

On updating an existing session we must use the un-hashed
sessionId to query the existing session.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Markus Klein uploaded patch set 1 11/18/20, 15:32

  2. Andreas Kienast commented on patch set 1 11/18/20, 15:36

    RedisSessionBackend.php:218

    Should we move this call below the try/catch block?
  3. TYPO3com voted on patch set 1 V +1 11/18/20, 15:45 Completed build in 12m 12s on Wed, 18 Nov, 03:45 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7398

  4. Thomas Hohn voted on patch set 1 V +1 CR +1 11/19/20, 07:51

  5. Markus Klein commented on patch set 1 11/19/20, 15:15

    RedisSessionBackend.php:218 Reply Unresolved

    thought about it, but wanted to make this regression fix as small as possible
  6. Markus Klein commented on patch set 1 CR -1 11/20/20, 13:03

    will add funtional tests for this
  7. Markus Klein uploaded patch set 2 11/20/20, 20:09

  8. TYPO3com voted on patch set 2 V +1 11/20/20, 20:21 Completed build in 11m 21s on Fri, 20 Nov, 08:21 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7497

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 11/20/20, 20:49

  10. Daniel Haupt voted on patch set 2 V +1 CR +1 11/21/20, 17:53

  11. Daniel Haupt wrote 11/21/20, 17:53

    Removed Verified+1 by Daniel Haupt <mail@danielhaupt.de>
  12. Benni Mack voted on patch set 2 V +2 CR +2 11/25/20, 12:57

  13. Benni Mack merged patch set 3 11/25/20, 12:58