Review main Merged

66698[TASK] Always use fluid based page module

Georg Ringer CR +2 V +2 Normal +42 −34 updated 11/24/20, 16:57

Commit message

The feature toggle for `fluidBasedPageModule` is removed
to enforce the use of the new fluid based page module.

The already deprecated `PageLayoutView` will finally
be removed in a separate patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1115

  1. Georg Ringer uploaded patch set 1 11/18/20, 15:57

  2. Georg Ringer commented on patch set 1 11/18/20, 15:58

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 11/18/20, 16:10 Completed build in 12m 51s on Wed, 18 Nov, 04:10 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7401

  4. Benni Mack uploaded patch set 2 11/18/20, 16:46

  5. Benni Mack commented on patch set 3 11/18/20, 16:52

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 2 V +1 11/18/20, 17:02 Completed build in 15m 58s on Wed, 18 Nov, 05:02 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7403

  7. TYPO3com voted on patch set 3 V +1 11/18/20, 17:12 Completed build in 19m 36s on Wed, 18 Nov, 05:12 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7405

  8. Claus Due commented on patch set 3 11/20/20, 12:55

    Features.php:67 Unresolved

    I assume this is here for third-parties which are checking the feature-enabled state? So even though the feature technically doesn't exist anymore, third-party code would enter a mode that is compatible with the fluid based page module?
  9. Christian Kuhn commented on patch set 3 11/20/20, 13:08

    What is the state of those rather often used extensions like gridelements / container / others regarding the fluid based page module?
  10. Claus Due commented on patch set 3 11/20/20, 13:14

    > Patch Set 3: > > What is the state of those rather often used extensions like gridelements / container / others regarding the fluid based page module? Flux has a check for this mode: https://github.com/FluidTYPO3/flux/blob/development/Classes/Integration/PreviewView.php#L346 It's fully compatible with this feature enabled or disabled.
  11. Oli Bartsch uploaded patch set 4 11/24/20, 13:07

  12. Oli Bartsch commented on patch set 4 V +1 CR +1 11/24/20, 13:13

    I'm in favor of continuing with this now to get it into 11.0. Extension authors, as correctly noted by Christian, should get enough time to adjust there extensions.
  13. TYPO3com voted on patch set 4 V +1 11/24/20, 13:19 Completed build in 11m 49s on Tue, 24 Nov, 01:19 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7543

  14. Benni Mack voted on patch set 4 V +2 CR +2 11/24/20, 16:57

  15. Benni Mack merged patch set 5 11/24/20, 16:57