Review main Merged

66699[TASK] Variable type hints for makeInstance(self::class)

Christian Kuhn CR +2 V +2 Easy +5 −1 updated 11/20/20, 11:38

Commit message

It seems the DynamicReturnTypePlugin for PhpStorm does
not deal with 'self::class'. Change a couple of
makeInstance() calls to hint for the returned object.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 89

  1. Christian Kuhn uploaded patch set 1 11/19/20, 13:41

  2. Mathias Brodala commented on patch set 1 11/19/20, 13:48

    Since self::class is basically the same as __CLASS__, can't we use the latter? (Assuming the latter actually works with the plugin.)
  3. TYPO3com voted on patch set 1 V +1 11/19/20, 13:54 Completed build in 13m 24s on Thu, 19 Nov, 01:54 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7422

  4. Christian Kuhn commented on patch set 1 11/20/20, 10:34

    __CLASS__ is not detected / understood by the plugin, either.
  5. Mathias Brodala voted on patch set 1 CR +1 11/20/20, 10:48

  6. Oliver Klee voted on patch set 1 CR +1 11/20/20, 11:00

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 11/20/20, 11:30

  8. Anja Leichsenring voted on patch set 1 V +2 CR +2 11/20/20, 11:38

  9. Anja Leichsenring merged patch set 2 11/20/20, 11:38