Review main Merged

66700[BUGFIX] Correct uri in functional test

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 11/19/20, 15:05

Commit message

Handing over '/' as $uri to InternalRequest() in functional
tests triggers an ugly fallback mechanism that changes this to
'http://localhost/' within the FE call.
Not handing over any $uri string at all defaults to
'http://localhost/' too, but at an much earlier and more
transparent point.
The patch streamlines two places that used the above method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 11/19/20, 13:54

  2. TYPO3com voted on patch set 1 V +1 11/19/20, 14:06 Completed build in 12m 11s on Thu, 19 Nov, 02:06 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7423

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/19/20, 15:05

  4. Benni Mack merged patch set 2 11/19/20, 15:05