Review main Merged

66708[TASK] Public method to retrieve class loader

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 11/19/20, 20:55

Commit message

To bootstrap TYPO3 sub requests, the testing framework needs an
instance of the class loader. There is no good way to retrieve
this object that is immutable for the entire process.

During casual bootstrap, an instance of the class loader is parked
in object ClassLoadingInformation. The patch makes getClassLoader()
public to allow retrieval.

This solution is kinda ugly and should probably change later. The
public method is for now marked @internal and should not be used
by third party code to allow structural changes later.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 11/19/20, 17:03

  2. TYPO3com voted on patch set 1 V +1 11/19/20, 17:15 Completed build in 12m 29s on Thu, 19 Nov, 05:15 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7428

  3. Georg Ringer voted on patch set 1 V +1 CR +1 11/19/20, 18:05

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/19/20, 20:55

  5. Benni Mack merged patch set 2 11/19/20, 20:55