Review main Merged

66710[FEATURE] AbstractApplication implements PSR-15 RequestHandlerInterface

Christian Kuhn CR +2 V +2 Easy +41 −5 updated 11/19/20, 20:53

Commit message

Frontend, backend and install tool application classes are the
main entry points to create a response from a request object.

From within a HTTP index.php, run() is called, which creates the
request object from globals and feeds that to handle().

But, to retrieve a TYPO3 response from within a different PHP
application, or from within TYPO3 itself (eg. a backend calls a
frontend), the leading application would want to hand over a
given or specially crafted PSR-7 ServerRequest directly.

This is exactly what PSR-15 RequestHandlerInterface is for.

By implementing this inteface in the application classes, the
core increases interoperability significantly and allows to
be easily called by a third party PHP application.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 45

  1. Christian Kuhn uploaded patch set 1 11/19/20, 18:15

  2. TYPO3com voted on patch set 1 V +1 11/19/20, 18:32 Completed build in 16m 22s on Thu, 19 Nov, 06:32 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7434

  3. Georg Ringer voted on patch set 1 CR +1 11/19/20, 18:32

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/19/20, 20:52

  5. Benni Mack merged patch set 2 11/19/20, 20:53