Review main Merged

66717[TASK] Raise PHP requirements to PHP 7.4

Benni Mack CR +2 V +2 Normal +25 −27 updated 11/20/20, 14:07

Commit message

The PHP version that is required now, is PHP 7.4,
more specifically PHP 7.4.1, which fixed a
hard issue on the JIT compiler.

Used composer commands:
composer config platform.php 7.4.1
composer req php:^7.4
composer req php:^7.4 -d typo3/sysext/core --no-lock

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 911

  1. Benni Mack uploaded patch set 1 11/20/20, 11:38

  2. Christian Kuhn commented on patch set 1 11/20/20, 11:42

    runTest.sh needs adaption to not allow -p 7.2/7.3 anymore.
  3. TYPO3com voted on patch set 1 V +1 11/20/20, 11:55 Completed build in 14m 57s on Fri, 20 Nov, 11:55 AM Test Summary: 32377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7453

  4. Benni Mack uploaded patch set 2 11/20/20, 13:36

  5. TYPO3com voted on patch set 2 V +1 11/20/20, 13:53 Completed build in 15m 34s on Fri, 20 Nov, 01:53 PM Test Summary: 32377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7462

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/20/20, 14:01

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 11/20/20, 14:06

  8. Christian Kuhn voted on patch set 2 V 0 CR 0 11/20/20, 14:06

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 11/20/20, 14:07

  10. Benni Mack voted on patch set 2 V +2 CR +2 11/20/20, 14:07

  11. Benni Mack merged patch set 3 11/20/20, 14:07