Review 10.4 Abandoned

66732[BUGFIX] Fetch original row from database when previewing a workspace

huelsmc CR 0 V 0 Easy +20 −8 updated 04/30/21, 10:50

Commit message

In the context of Extbase persistence layer fetching translated relations
within a workspace, the data to be overlaid may contain additional columns
from the MM relation table.

In order to prevent those columns to be queried, the vanilla record
should be fetched prior to try to overlay it.

If needed, additional columns from the JOIN are restored after the overlay
has been prepared.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. huelsmc uploaded patch set 1 11/20/20, 12:44

  2. TYPO3com voted on patch set 1 V +1 11/20/20, 12:56 Completed build in 12m 28s on Fri, 20 Nov, 12:56 PM Test Summary: 75162 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-818

  3. Sebastian Michaelsen commented on patch set 1 V +1 12/01/20, 12:30

    Tested in a 10.4 installation where this issue occured. This patch fixes the problem.
  4. Benni Mack voted on patch set 1 CR +1 12/04/20, 06:14

  5. Uwe Trotzek commented on patch set 1 V +1 12/10/20, 11:42

    Fixes the issue in our TYPO3 10.4.10 project as well
  6. Benni Mack abandoned the change 04/30/21, 10:50