Review main Merged

66733[TASK] Raise Doctrine dependencies to be PHP 8 compatible

Benni Mack CR +2 V +2 Normal +68 −42 updated 11/24/20, 18:18

Commit message

used composer commands
* composer req "doctrine/annotations:^1.11.0"
* composer req "doctrine/instantiator:^1.4.0"
* composer req "doctrine/lexer:^1.2.1"

Doctrine DBAL will be handled separately

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 11/20/20, 14:11

  2. TYPO3com voted on patch set 1 V -1 11/20/20, 14:22 Completed build in 08m 49s on Fri, 20 Nov, 02:22 PM Test Summary: 11615 of 11785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7465

  3. Benni Mack uploaded patch set 2 11/24/20, 16:19

  4. TYPO3com voted on patch set 2 V +1 11/24/20, 16:30 Completed build in 10m 43s on Tue, 24 Nov, 04:30 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7546

  5. Georg Ringer voted on patch set 2 V +1 CR +1 11/24/20, 17:26

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 11/24/20, 18:18

  7. Christian Kuhn merged patch set 3 11/24/20, 18:18