Review 10.4 Merged

66752[BUGFIX] Make non-visible l10n_parent fields of type group

Anja Leichsenring CR +2 V +2 Easy +12 −14 updated 11/20/20, 13:23

Commit message

The l10n_parent fields of sys_file_metadata and sys_file_reference are
never shown anywhere. Having them as type 'select' in the TCA causes the
FormEngine to try loading all possible parent value, which can be
thousands or more. This degrades backend performance towards unusable.

Changing the TCA definition to 'group' mitigates the issue easily as no
lookup list has to be created/loaded.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 11/20/20, 12:46

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/20/20, 13:05 Completed build in 17m 47s on Fri, 20 Nov, 01:05 PM Test Summary: 75161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-819

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 11/20/20, 13:23

  4. Anja Leichsenring merged patch set 2 11/20/20, 13:23