Review 10.4 Merged

66757[BUGFIX] Use button tag for modal buttons in InlineControlContainer

Benni Mack CR +2 V +2 Normal +37 −40 updated 11/20/20, 16:03

Commit message

Instead of <a href="#" ...> or <span ...>, a <button> tag is used for
inline relations to enable proper keyboard navigation.

* rename variable and protected method names from "link" to "button"
* remove unsed $objectPrefix argument from getLevelInteractionLink
  (now ...Button)

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 11/20/20, 15:18

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/20/20, 15:32 Completed build in 11m 41s on Fri, 20 Nov, 03:32 PM Test Summary: 1 of 75659 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-828

  3. TYPO3com voted on patch set 1 V +1 11/20/20, 15:57 Completed build in 48m 25s on Fri, 20 Nov, 03:57 PM Test Summary: 75174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-828

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/20/20, 16:03

  5. Benni Mack merged patch set 2 11/20/20, 16:03