Review 10.4 Merged

66759[BUGFIX] Make sure external link checks time out

Benni Mack CR +2 V +2 Normal +172 −0 updated 11/21/20, 20:23

Commit message

The HTTP requests for checking external links did not have a
timeout. The timeout from Global Configuration was used
which is set to 0 (not timeout) by default.

This could cause the link checking to run
indefinitely and scheduler tasks to never terminate.

Usually, there is a connect timeout, a read timeout
and a total timeout. We set the total timeout and make
this configurable via page TSconfig.

If this is not set via TSconfig, it will default to the
value set in $GLOBALS['TYPO3_CONF_VARS']['HTTP']['timeout'].

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack commented on patch set 1 11/20/20, 15:57

    Cherry Picked from branch master.
  2. Christian Kuhn commented on patch set 1 11/20/20, 16:01

    ExternalLinktype.php:80

    benni. haha. you didn't read my comment regarding the v10 backport, did you?
  3. TYPO3com voted on patch set 1 V -1 11/20/20, 16:16 Completed build in 32s on Fri, 20 Nov, 04:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-830

  4. Benni Mack commented on patch set 1 11/20/20, 16:17

    ExternalLinktype.php:80 Reply Unresolved

  5. Christian Kuhn uploaded patch set 2 11/20/20, 16:25

  6. TYPO3com voted on patch set 2 V +1 11/20/20, 16:54 Completed build in 21m 07s on Fri, 20 Nov, 04:54 PM Test Summary: 75180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-833

  7. Benni Mack commented on patch set 2 V +2 CR +2 11/21/20, 20:23

    Thx Christian!
  8. Benni Mack merged patch set 3 11/21/20, 20:23