Review main Merged

6676[BUGFIX] Set currentVal in 2nd rendering loop of IMGTEXT

Christian Welzel CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

Set the currentVal to the current filename during rendering of
HTML in the second rendering loop. This makes current=1 useful for
rendering captions.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Files 1

Review log 16

  1. Gerrit wrote 12/18/11, 19:31

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Stefan Neufeind commented on patch set 1 12/18/11, 19:31

    Looks okay. But please check against older releases and and a Releases: line to the commit-message accordingly.
  3. Stefan Neufeind commented on patch set 2 12/18/11, 19:31

    Looks good to me, but someone else must approve
  4. Christian Welzel uploaded patch set 2 12/18/11, 19:31

  5. Steffen Ritter commented on patch set 2 V 0 12/18/11, 19:31

    by team member
  6. Steffen Ritter commented on patch set 2 12/18/11, 19:31

    Looks good to me, approved
  7. Steffen Ritter commented on patch set 2 12/18/11, 19:31

    Verified; Looks good to me, but someone else must approve Looks like a no-brainer to me...
  8. Markus Klein commented on patch set 3 12/18/11, 19:31

    How does this apply to 4.5??
  9. Steffen Ritter uploaded patch set 3 12/18/11, 19:31

  10. Steffen Ritter commented on patch set 3 V 0 12/18/11, 19:31

    by team member; Looks good to me, approved manual "cherry-pick" change...
  11. Steffen Ritter merged patch set 3 12/18/11, 19:31

  12. Mr. Jenkins commented on patch set 1 12/18/11, 19:31

  13. Mr. Jenkins commented on patch set 2 12/18/11, 19:31

  14. Mr. Jenkins commented on patch set 3 12/18/11, 19:31

  15. Dominik Mathern commented on patch set 2 12/18/11, 19:31

    Verified; Looks good to me, but someone else must approve
  16. Markus Klein commented on patch set 3 12/18/11, 19:31

    Completely different code for 4.6 and 4.5. Please push new code for backports.