Review 10.4 Merged

66760[BUGFIX] Use a HTML button for the collapsable IRRE header

Benni Mack CR +2 V +2 Normal +69 −19 updated 11/21/20, 20:22

Commit message

Also add aria-expanded and aria-controls arguments for screen readers

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Benni Mack commented on patch set 1 11/20/20, 16:01

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/Css/backend.css * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js
  2. Benni Mack uploaded patch set 2 11/20/20, 16:29

  3. TYPO3com voted on patch set 1 V -1 11/20/20, 16:36 Completed build in 20m 45s on Fri, 20 Nov, 04:36 PM Test Summary: 12 of 75659 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-831

  4. Benni Mack commented on patch set 2 11/20/20, 16:38

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 11/20/20, 16:59 Completed build in 26m 22s on Fri, 20 Nov, 04:59 PM Test Summary: 75174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-834

  6. Benni Mack voted on patch set 2 V +2 CR +2 11/21/20, 20:22

  7. Benni Mack merged patch set 3 11/21/20, 20:22