Review 10.4 Abandoned

66792[WIP][TASK] Reorganize sudo mode handling

Oliver Hader CR 0 V 0 Expert +1573 −303 updated 04/08/23, 14:13

Commit message

* move to ext:backend for further adjustments
* decouple from ext:install, use backend session instead
* avoid mixing install tool global `$_SESSION` object with
  session handling of 3rd party authentication services
* introduce generic demand handling interfaces
* add sudo mode declaration for backend routes

@todo
* finalize implementation (names, namespaces, PSR-14)
* apply changes of issue #93160 (development context)
* use dependency injection & factories where possible
* try to pipe storage invocations through DemandHandler
* adjust documentation

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 28

Show 8 more files

Review log 814

  1. Oliver Hader uploaded patch set 1 11/20/20, 22:33

  2. TYPO3com voted on patch set 1 V -1 11/20/20, 22:44 Completed build in 11m 18s on Fri, 20 Nov, 10:44 PM Test Summary: 48 of 75659 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-835

  3. Oliver Hader uploaded patch set 2 05/31/21, 14:43

  4. core-ci voted on patch set 2 V -1 05/31/21, 14:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12042

  5. Oliver Hader uploaded patch set 3 05/31/21, 15:18

  6. core-ci voted on patch set 3 V -1 05/31/21, 15:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12044

  7. Oliver Hader marked it work in progress 11/18/21, 10:48

  8. Oliver Hader uploaded patch set 4 V -1 12/06/22, 18:04

  9. core-ci voted on patch set 4 V -1 12/06/22, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34732

  10. Oliver Hader uploaded patch set 5 V -1 12/06/22, 19:13

  11. core-ci voted on patch set 5 V -1 12/06/22, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34734

  12. Oliver Hader uploaded patch set 6 V -1 12/06/22, 19:58

  13. core-ci voted on patch set 6 V +1 12/06/22, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34736

  14. Oliver Hader abandoned the change 04/08/23, 14:13