Review main Abandoned

66794[BUGFIX] Lock focusArea only while dragging cropper area

Andreas Kienast CR 0 V 0 Easy +23 −5 updated 10/13/21, 08:45

Commit message

With the migration to the now used cropping library, dragging focus
areas broke due to two reasons:

* Listener for `dragstart` event disables the focus area, but the
  `dragend` event is never fired, if a focus area is about to get moved
* Dragging anything but the cropper itself became possible by pressing
  the CTRL key only due to changes in the cropping library

This patch now disables and enables the focus area only if not the focus
area itself is moved. Additionally, a ReST file is added to make aware
of the changed dragging behavior.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 812

  1. Andreas Kienast uploaded patch set 1 11/21/20, 08:57

  2. TYPO3com voted on patch set 1 V +1 11/21/20, 09:14 Completed build in 16m 52s on Sat, 21 Nov, 09:14 AM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7500

  3. Andreas Kienast updated the commit message in patch set 2 12/12/20, 16:32

  4. TYPO3com voted on patch set 2 V -1 12/12/20, 16:41 Completed build in 09m 07s on Sat, 12 Dec, 04:41 PM Test Summary: 1 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8123

  5. TYPO3com voted on patch set 2 V +1 12/14/20, 07:01 Completed build in 09m 59s on Mon, 14 Dec, 07:01 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8141

  6. Andreas Kienast uploaded patch set 3 12/21/20, 16:05

  7. TYPO3com voted on patch set 3 V +1 12/21/20, 16:16 Completed build in 10m 44s on Mon, 21 Dec, 04:16 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8383

  8. Markus Klein voted on patch set 3 CR +1 01/16/21, 11:32

  9. Richard Haeser commented on patch set 3 V -1 01/16/21, 16:53

    On a Mac using the CTRL-key is bound to a right-click causing the browser context menu showing up when trying to move the focus area.
  10. Andreas Kienast commented on patch set 3 01/16/21, 17:22

    Reply

    Great catch, will check whether this can be circumvented somehow.
  11. Benni Mack commented on patch set 3 10/08/21, 08:12

    ping. If there is no progress, I will abandon this change for the time being.
  12. Andreas Kienast abandoned the change 10/13/21, 08:45

    abandoned for the time being