Review 9.5 Merged

66833[BUGFIX] Add focus to user confirmation password field

Frank Nägler CR +2 V +2 Easy +35 −0 updated 01/16/21, 10:04

Commit message

Since #92836 backend users have to confirm their
password on accessing the install tool in the backend.

The corresponding password field now properly gets
the focus assigned. This improves the accessibility,
especially for keyboard users who otherwise had to
tab through the whole module menu first.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 913

  1. Frank Nägler commented on patch set 1 11/22/20, 17:55

    Cherry Picked from branch 10.4.
  2. Frank Nägler commented on patch set 1 V -1 11/22/20, 18:06

    needs an adjustment
  3. TYPO3com voted on patch set 1 V +1 11/22/20, 18:11 Completed build in 15m 41s on Sun, 22 Nov, 06:11 PM Test Summary: 75306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-923

  4. Frank Nägler uploaded patch set 2 11/22/20, 18:22

  5. TYPO3com voted on patch set 2 V +1 11/22/20, 18:35 Completed build in 12m 48s on Sun, 22 Nov, 06:35 PM Test Summary: 75306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-924

  6. Frank Nägler voted on patch set 2 V +1 CR +1 11/22/20, 18:36

  7. Frank Nägler commented on patch set 2 V 0 CR -1 11/22/20, 18:41

    this patch should use jQuery instead of a backport of the DocumentService. @Oliver Bartsch, could take care?
  8. Oli Bartsch commented on patch set 2 11/22/20, 19:00

    > Patch Set 2: -Verified Code-Review-1 > > this patch should use jQuery instead of a backport of the DocumentService. > @Oliver Bartsch, could take care? Yes, will do.
  9. Oli Bartsch uploaded patch set 3 11/23/20, 10:05

  10. TYPO3com voted on patch set 3 V -1 11/23/20, 14:28 Completed build in 22m 06s on Mon, 23 Nov, 02:28 PM Test Summary: 1 of 75906 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-925

  11. TYPO3com voted on patch set 3 V +1 11/23/20, 14:47 Completed build in 12m 06s on Mon, 23 Nov, 02:47 PM Test Summary: 75306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-926

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 01/16/21, 10:04

  13. Andreas Kienast merged patch set 4 01/16/21, 10:04