66852[BUGFIX] Do not hand invalid input to ResourceFactory
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oli Bartsch +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1215
-
Daniel Goerz uploaded patch set 1 11/23/20, 16:07
-
Mathias Brodala updated the commit message in patch set 2 11/23/20, 16:12
-
Simon Gilli voted on patch set 2 CR +1 11/23/20, 16:18
-
TYPO3com voted on patch set 1 V +1 11/23/20, 16:19 Completed build in 11m 26s on Mon, 23 Nov, 04:19 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7522
-
TYPO3com voted on patch set 2 V +1 11/23/20, 16:23 Completed build in 10m 48s on Mon, 23 Nov, 04:23 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7523
-
Martin Kutschker commented on patch set 2 V +1 11/23/20, 16:35
Form specified as EXT: works again. -
Simon Gilli voted on patch set 2 V +1 11/23/20, 16:36
-
Oli Bartsch commented on patch set 2 11/23/20, 17:02
PropertyMappingConfiguration.php:128UnresolvedCan we just use strpos directly? Since the haystack is a type-hinted variable and the needle is static, I don't see the need to use the utility function here. -
Martin Kutschker commented on patch set 3 11/23/20, 19:46
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 11/23/20, 19:57 Completed build in 11m 02s on Mon, 23 Nov, 07:57 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7525
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 11/24/20, 06:29
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/24/20, 08:38
-
Daniel Goerz voted on patch set 3 CR +1 11/24/20, 08:46
-
Benni Mack voted on patch set 3 V +2 CR +2 11/27/20, 08:28
-
Benni Mack merged patch set 4 11/27/20, 08:28