Review main Merged

66852[BUGFIX] Do not hand invalid input to ResourceFactory

Daniel Goerz CR +2 V +2 Easy +4 −0 updated 11/27/20, 08:28

Commit message

A phpstan related patch revealed a flaw in EXT:form
PropertyMappingConfiguration when an "EXT:" path was
passed to the FAL ResourceFactory.

Instead of relying on the InvalidArgumentException
this patch now prevents the invalid argument from being
passed in the first place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1215

  1. Daniel Goerz uploaded patch set 1 11/23/20, 16:07

  2. Mathias Brodala updated the commit message in patch set 2 11/23/20, 16:12

  3. Simon Gilli voted on patch set 2 CR +1 11/23/20, 16:18

  4. TYPO3com voted on patch set 1 V +1 11/23/20, 16:19 Completed build in 11m 26s on Mon, 23 Nov, 04:19 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7522

  5. TYPO3com voted on patch set 2 V +1 11/23/20, 16:23 Completed build in 10m 48s on Mon, 23 Nov, 04:23 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7523

  6. Martin Kutschker commented on patch set 2 V +1 11/23/20, 16:35

    Form specified as EXT: works again.
  7. Simon Gilli voted on patch set 2 V +1 11/23/20, 16:36

  8. Oli Bartsch commented on patch set 2 11/23/20, 17:02

    PropertyMappingConfiguration.php:128 Unresolved

    Can we just use strpos directly? Since the haystack is a type-hinted variable and the needle is static, I don't see the need to use the utility function here.
  9. Martin Kutschker commented on patch set 3 11/23/20, 19:46

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 11/23/20, 19:57 Completed build in 11m 02s on Mon, 23 Nov, 07:57 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7525

  11. Alexander Schnitzler voted on patch set 3 V +1 CR +1 11/24/20, 06:29

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 11/24/20, 08:38

  13. Daniel Goerz voted on patch set 3 CR +1 11/24/20, 08:46

  14. Benni Mack voted on patch set 3 V +2 CR +2 11/27/20, 08:28

  15. Benni Mack merged patch set 4 11/27/20, 08:28