66872[FEATURE] Add registration for DataProcessor
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Feature-92910-AddDataProcessorRegistration.rst3new+48 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentDataProcessor.php+17 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+20 −0
- typo3/sysext/frontend/ext_localconf.php+12 −0
Review log 913
-
Thomas Löffler uploaded patch set 1 11/23/20, 17:05
-
TYPO3com voted on patch set 1 V +1 11/23/20, 17:17 Completed build in 11m 47s on Mon, 23 Nov, 05:17 PM Test Summary: 32393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7524
-
Thomas Löffler updated the commit message in patch set 2 11/24/20, 07:13
-
TYPO3com voted on patch set 2 V +1 11/24/20, 07:25 Completed build in 11m 13s on Tue, 24 Nov, 07:25 AM Test Summary: 32393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7532
-
Thomas Löffler uploaded patch set 3 11/24/20, 07:35
-
TYPO3com voted on patch set 3 V -1 11/24/20, 07:48 Completed build in 12m 48s on Tue, 24 Nov, 07:48 AM Test Summary: 30856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7533
-
Thomas Löffler uploaded patch set 4 11/24/20, 07:58
-
TYPO3com voted on patch set 4 V +1 11/24/20, 08:09 Completed build in 10m 38s on Tue, 24 Nov, 08:09 AM Test Summary: 32392 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7534
-
Christian Kuhn commented on patch set 4 CR -1 11/24/20, 18:50
-
Christian Kuhn commented on patch set 4 11/24/20, 18:59
Feature-92910-AddDataProcessorRegistration.rst:33Reply UnresolvedAh, got that right now: You're actually adding this array to typo3_conf_vars with this patch. I'd love to not do that: globally overriding a data processor is available already via 'xclass' if really needed for whatever reason, and I don't think having a full class name in TypoScript is a huge drawback. At least they allow me to easily find the implementation of a processor without further trouble. I don't see why should alias this, except the fact that this is less to type for a TypoScript dev: It makes TypoScript more opaque and adds naming trouble. -
Georg Ringer commented on patch set 4 CR -1 11/24/20, 21:27
Feature-92910-AddDataProcessorRegistration.rst:37UnresolvedI really don't like because of following reasons: - If I want to be consistent, now I need to add every DataProcessor to the $GLOBALS as well, even if only used once - If I check out a project which I don't know by heart, I *always* need to check out $globals as well which brings me to the next one: - the configuration might be in LocalConfiguration, it can be in one those AdditionalConfiguration_Production_Live.php files or in an ext_localconf.php of a site extension - PhpStorm let me (I guess because of one of those great plugins) click on the class and it will open right aways. this won't work then anymore -
Benni Mack commented on patch set 4 11/11/21, 10:41
I think this approach is better... https://review.typo3.org/c/Packages/TYPO3.CMS/+/72029 - the container keeps all the data processors, makes much more sense. -
Benni Mack abandoned the change 11/11/21, 10:41
see my comment
Feature-92910-AddDataProcessorRegistration.rst:33