Review main Abandoned

66873[BUGFIX] Fix color contrast and focus style for form elements

Michael Telgkamp CR 0 V 0 Easy +3 −3 updated 05/04/21, 18:31

Commit message

Change the colors of variables $input-border and $input-border-focus
to have a valid color contrast.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 913

  1. Michael Telgkamp uploaded patch set 1 11/23/20, 19:54

  2. Michael Telgkamp uploaded patch set 2 11/23/20, 19:56

  3. TYPO3com voted on patch set 1 V -1 11/23/20, 20:07 Completed build in 12m 05s on Mon, 23 Nov, 08:07 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7526

  4. TYPO3com voted on patch set 2 V +1 11/23/20, 20:09 Completed build in 13m 25s on Mon, 23 Nov, 08:09 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7527

  5. Michael Telgkamp wrote 11/23/20, 20:39

    Topic set to a11y
  6. Torben Hansen voted on patch set 2 V +1 CR +1 11/24/20, 08:21

  7. Oli Bartsch commented on patch set 2 11/24/20, 08:57

    Really appreciate this a11y improvements. However, IMO we should rather make one patch changing such contrasts consistent in one go. Otherwise we'll have a mess of different colors in various modules / places through the backend. E.g. I just search for the color codes changed here (#aaa, #bbb). They are still used as "border-color" at multiple other places (e.g. `form-control`, `form-group`, choosen lib, and so on).
  8. Benni Mack uploaded patch set 3 05/04/21, 12:13

  9. core-ci voted on patch set 3 V +1 05/04/21, 12:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11097

  10. Benni Mack uploaded patch set 4 05/04/21, 18:05

  11. Daniel Goerz commented on patch set 4 V -1 05/04/21, 18:14

    Cant see no differences
  12. core-ci voted on patch set 4 V +1 05/04/21, 18:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11144

  13. Daniel Goerz abandoned the change 05/04/21, 18:31

    Please re-push for master if changes are still necessary.