Review main Merged

66874[TASK] Fix color contrast for label-success

Michael Telgkamp CR +2 V +2 Easy +6 −1 updated 01/22/21, 19:39

Commit message

Add bootstrap class label-success to _element_label.scss.

Font color set to black and background color to a 20% lighter
$brand-success color.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1318

  1. Michael Telgkamp uploaded patch set 1 11/23/20, 20:03

  2. TYPO3com voted on patch set 1 V +1 11/23/20, 20:16 Completed build in 12m 40s on Mon, 23 Nov, 08:16 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7528

  3. Michael Telgkamp wrote 11/23/20, 20:40

    Topic set to a11y
  4. Daniel Haupt commented on patch set 1 V +1 CR +1 11/24/20, 00:35

    One minor styling proposal, but else this change is fine IMO.

    _element_label.scss:5

    What do you think about a little more bright styling, e.g.: .label-success { color: darken($brand-success, 25%); background-color: lighten($brand-success, 40%); } contrast: https://webaim.org/resources/contrastchecker/?fcolor=384C21&bcolor=DDEACF Looking forward hearing your opinion.
  5. Michael Telgkamp uploaded patch set 2 11/30/20, 16:39

  6. Michael Telgkamp commented on patch set 2 11/30/20, 16:42

    _element_label.scss:5 Reply

    I also prefer the adjusted color values and pushed a new patchset with the adjustments.
  7. TYPO3com voted on patch set 2 V +1 11/30/20, 16:51 Completed build in 11m 58s on Mon, 30 Nov, 04:51 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7704

  8. Benni Mack uploaded patch set 3 12/04/20, 18:42

  9. TYPO3com voted on patch set 3 V -1 12/04/20, 18:51 Completed build in 09m 15s on Fri, 4 Dec, 06:51 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7808

  10. Benni Mack commented on patch set 3 01/20/21, 21:11

    Care to update that patch @michael?
  11. Andreas Kienast commented on patch set 3 01/22/21, 16:44

    package.json:2

    Where does this change from?
  12. Andreas Kienast uploaded patch set 4 01/22/21, 16:46

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 01/22/21, 16:47

  14. TYPO3com voted on patch set 4 V -1 01/22/21, 16:57 Completed build in 10m 35s on Fri, 22 Jan, 04:57 PM Test Summary: 31860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8994

  15. TYPO3com voted on patch set 4 V +1 01/22/21, 17:40 Completed build in 1h 03m 53s on Fri, 22 Jan, 05:40 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8994

  16. Michael Telgkamp commented on patch set 4 V +1 CR +1 01/22/21, 18:09

    package.json:2 Reply Unresolved

    This is a change from the accessibility Sprint in October last year.
  17. Benni Mack voted on patch set 4 V +2 CR +2 01/22/21, 19:38

  18. Benni Mack merged patch set 5 01/22/21, 19:39