66874[TASK] Fix color contrast for label-success
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1318
-
Michael Telgkamp uploaded patch set 1 11/23/20, 20:03
-
TYPO3com voted on patch set 1 V +1 11/23/20, 20:16 Completed build in 12m 40s on Mon, 23 Nov, 08:16 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7528
-
Michael Telgkamp wrote 11/23/20, 20:40
Topic set to a11y -
Daniel Haupt commented on patch set 1 V +1 CR +1 11/24/20, 00:35
One minor styling proposal, but else this change is fine IMO._element_label.scss:5What do you think about a little more bright styling, e.g.: .label-success { color: darken($brand-success, 25%); background-color: lighten($brand-success, 40%); } contrast: https://webaim.org/resources/contrastchecker/?fcolor=384C21&bcolor=DDEACF Looking forward hearing your opinion. -
Michael Telgkamp uploaded patch set 2 11/30/20, 16:39
-
Michael Telgkamp commented on patch set 2 11/30/20, 16:42
_element_label.scss:5ReplyI also prefer the adjusted color values and pushed a new patchset with the adjustments. -
TYPO3com voted on patch set 2 V +1 11/30/20, 16:51 Completed build in 11m 58s on Mon, 30 Nov, 04:51 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7704
-
Benni Mack uploaded patch set 3 12/04/20, 18:42
-
TYPO3com voted on patch set 3 V -1 12/04/20, 18:51 Completed build in 09m 15s on Fri, 4 Dec, 06:51 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7808
-
Benni Mack commented on patch set 3 01/20/21, 21:11
Care to update that patch @michael? -
Andreas Kienast commented on patch set 3 01/22/21, 16:44
package.json:2Where does this change from? -
Andreas Kienast uploaded patch set 4 01/22/21, 16:46
-
Andreas Kienast voted on patch set 4 V +1 CR +1 01/22/21, 16:47
-
TYPO3com voted on patch set 4 V -1 01/22/21, 16:57 Completed build in 10m 35s on Fri, 22 Jan, 04:57 PM Test Summary: 31860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8994
-
TYPO3com voted on patch set 4 V +1 01/22/21, 17:40 Completed build in 1h 03m 53s on Fri, 22 Jan, 05:40 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8994
-
Michael Telgkamp commented on patch set 4 V +1 CR +1 01/22/21, 18:09
package.json:2Reply UnresolvedThis is a change from the accessibility Sprint in October last year. -
Benni Mack voted on patch set 4 V +2 CR +2 01/22/21, 19:38
-
Benni Mack merged patch set 5 01/22/21, 19:39