Review main Abandoned

66875[TASK] Accessibility of page column header

Michael Telgkamp CR 0 V 0 Normal +42 −11 updated 06/01/21, 07:34

Commit message

Increase contrast of icons, add headlines of the page column header.

Add alternative text to image icons.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 911

  1. Michael Telgkamp uploaded patch set 1 11/23/20, 20:33

  2. TYPO3com voted on patch set 1 V -1 11/23/20, 20:33 Completed build in 20s on Mon, 23 Nov, 08:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7530

  3. Michael Telgkamp wrote 11/23/20, 20:40

    Topic set to a11y
  4. Michael Telgkamp uploaded patch set 2 11/23/20, 20:47

  5. TYPO3com voted on patch set 2 V -1 11/23/20, 20:59 Completed build in 11m 27s on Mon, 23 Nov, 08:59 PM Test Summary: 907 of 32632 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7531

  6. Michael Telgkamp commented on patch set 2 V -1 CR -1 11/23/20, 21:05

    The test suites also need to be adjust for this to work.
  7. Oli Bartsch commented on patch set 2 V -1 CR -1 11/24/20, 09:19

    Not quite sure but since PageLayoutView is still supported by the time writing, it should be adjusted there, too. This patch currently only considers fluid based page module. Furthermore, since this introduces new functionality to public API (IconFactory) this should get at least an important.rst including the new Parameter and VH argument. Since this is only for master anyway, it could also be declared as feature patch. Last but not least, please cover this new functionality with tests. There are already the IconTest, IconViewHelperTest and IconFactoryTest classes in place which needs to be adjusted accordingly.

    IconFactory.php:87 Unresolved

    Please add type-hint for new parameters.

    IconFactory.php:489 Unresolved

    Please add type-hint for the new parameter.

    IconFactory.php:494 Unresolved

    The shorthanded if can be removed once the type-hint was added.

    IconViewHelper.php:73 Unresolved

    Must get a default value, so we can type-hint it in getIcon().
  8. Georg Ringer commented on patch set 2 11/24/20, 17:44

    @Oliver PageLayoutView will be gone and as there are visual changes this is master only => so just fixing the new fluid based page module is IMO fine
  9. Georg Ringer commented on patch set 2 11/24/20, 17:45

    SvgIconProvider.php:47 Unresolved

    please add htmlspecialchars() as well to avoid XSS
  10. Christian Kuhn commented on patch set 2 06/01/21, 07:34

    Hey. It seems as if work on this patch stalled. Together with the -1's on this patch, and for the sake of a cleaner review system, I'd say we should abandon the approach for now. I'll set the issue to 'new' again, to keep it open for a fresh patch when work is picked up again. The abandoned patch is still in the system and linked from the forge issue, no information is lost.
  11. Christian Kuhn abandoned the change 06/01/21, 07:34