Review main Merged

66876[BUGFIX] Fix the Formelement selection button on first use

Grégory Jaouën CR +2 V +2 Easy +1 −1 updated 08/11/21, 11:47

Commit message

Fix the Formelement selection button on first use. The variable
`propertyData` might be a string and the expression
`getCurrentlySelectedFormElement().get(propertyPath)` can return
an undefined value.
The OR operator `||` is used instead of the nullish coalescing
operator `??` on browser compatibility purpose.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1

Issues 1

Files 1

Review log 1012

  1. Grégory Jaouën uploaded patch set 1 11/24/20, 09:13

  2. TYPO3com voted on patch set 1 V +1 11/24/20, 09:25 Completed build in 11m 59s on Tue, 24 Nov, 09:25 AM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7535

  3. Oli Bartsch commented on patch set 1 11/24/20, 09:36

    Hi, thanks for your patch. I assume this should also be backported in 10.4? If so, please update the Releases line to "master, 10.4, 9.5"
  4. Grégory Jaouën updated the commit message in patch set 2 11/24/20, 09:49

  5. Grégory Jaouën commented on patch set 2 11/24/20, 09:54

    > Patch Set 1: > > Hi, thanks for your patch. I assume this should also be backported in 10.4? If so, please update the Releases line to "master, 10.4, 9.5" Hi, it's done.
  6. TYPO3com voted on patch set 2 V +1 11/24/20, 10:01 Completed build in 11m 22s on Tue, 24 Nov, 10:01 AM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7536

  7. Björn Jacob commented on patch set 2 CR -1 08/06/21, 12:10

    Don't think that this has to be backported to v9 since this version is in priority bugfix phase.
  8. Björn Jacob updated the commit message in patch set 3 08/11/21, 10:26

  9. Björn Jacob updated the commit message in patch set 4 08/11/21, 10:28

  10. Björn Jacob voted on patch set 4 V +1 CR +1 08/11/21, 11:43

  11. waldhacker voted on patch set 4 V +2 CR +2 08/11/21, 11:46

  12. waldhacker merged patch set 5 08/11/21, 11:47