Review main Merged

66877[BUGFIX] Allow removal of RegularExpression validator

Oli Bartsch CR +2 V +2 Easy +6 −0 updated 11/27/20, 08:22

Commit message

Add the missing "delete" button to the RegularExpression
validator for form elements "Telephone" and "Url", allowing
to remove a previously manually added validator again.

Note: The "Email" and "Number" form elements do both also
include validators which are missing the "delete" button. But
since this validators (email validator respectively number
validator) are added automatically on form element creation,
it's considered intended behaviour. Only validators which were
added manually must provide the option to delete them again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/24/20, 11:00

  2. TYPO3com voted on patch set 1 V +1 11/24/20, 11:11 Completed build in 11m 13s on Tue, 24 Nov, 11:11 AM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7540

  3. Georg Ringer voted on patch set 1 V +1 CR +1 11/24/20, 12:18

  4. Daniel Haupt voted on patch set 1 V +1 CR +1 11/27/20, 01:19

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 11/27/20, 08:22

  6. Daniel Goerz merged patch set 2 11/27/20, 08:22